1500963 - Pass a `renderStacktrace` prop to Reps

Status: RESOLVED FIXED

(DevTools :: Console, enhancement, P1)

Description

[Nicolas Chevobbe [:nchevobbe]]

In Bug 1390768, we are probably going to end up creating a new component that will wrap debugger's Frames component.
This component will be used by the console and other panels (netmonitor, …), but it would be also good to allow Reps that display a trace (i.e. Errors) to have access to this component.

The idea would be to pass a `renderStacktrace` function that would render the stacktrace with the new component.

This way, all the stacktraces displayed in devtools would be the same (and handle sourcemap).

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

This also depends on https://github.com/devtools-html/debugger.html/issues/7130

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Removing dependency on Bug 1390768 since we can already use the Stacktrace component in renderStacktrace.
Still need the next version of reps though.

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1500963 - Use the Stacktrace component in Error reps; r?bgrins.

This patch makes use of the new renderStacktrace
prop in Reps to render Error objects stacktraces
using the shared Stacktrace component.
This way we are showing stacktraces in a consistent
way, and as a bonus, we support sourcemap in Error
object.

Depends on D9922

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/006509a8370f
Use the Stacktrace component in Error reps; r=bgrins.

Comment 5

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/006509a8370f