1501104 - BigInt asIntN/asUintN methods

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P1)

Description

[Robin Templeton [:terpri]]

Implement asIntN and asUintN methods for BigInt values.

Comment 1

[Robin Templeton [:terpri]]

Attachment: bug 1501104 - Implement asIntN and asUintN methods for BigInt values.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/64b039293b0a
Implement asIntN and asUintN methods for BigInt values. r=wingo,jandem

Comment 3

[Cosmin Sabou [:CosminS]]

Backed out for causing SM bustages on non262/BigInt/large-bit-length.js.

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=busted&fromchange=64b039293b0aca1d038cc791ed914487cda42fe5&tochange=1fdba4aa936e303e2c40a888ea088666b0c4db21&selectedJob=210384674

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=210384674&repo=autoland&lineNumber=26679

Backout link: https://hg.mozilla.org/integration/autoland/rev/1fdba4aa936e303e2c40a888ea088666b0c4db21

Comment 4

[Robin Templeton [:terpri]]

The new test needed to be skipped when BigInt is disabled. Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=fc32bded49aedcfbc6de15dc7404067997f07b4b

Comment 5

[Jan de Mooij [:jandem]]

Can this land now, Robin?

Comment 6

[Robin Templeton [:terpri]]

Yes, it should be ready now, re-setting checkin-needed

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fa0c3cafea63
Implement asIntN and asUintN methods for BigInt values. r=wingo,jandem

Comment 8

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/fa0c3cafea63

Comment 9

[Chris Mills [:cmills]]

Note to MDN writers:

* I've not added a note to the Fx65 rel notes, as I believe BigInt is not yet enabled by default.
* These methods should however be documented.

Comment 10

[Florian Scholz (Open Web Docs)]

For doc pages written/updated, see https://github.com/mdn/sprints/issues/1002

(This shipped in 68 and these methods are documented here: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/BigInt/asIntN / https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/BigInt/asUintN)