Closed
Bug 1501106
Opened 2 years ago
Closed 2 years ago
Some cleanups for viewport handling
Categories
(Core :: Layout, enhancement, P3)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla65
Tracking | Status | |
---|---|---|
firefox65 | --- | fixed |
People
(Reporter: hiro, Assigned: hiro)
References
Details
Attachments
(3 files, 1 obsolete file)
I am going to drop nsIDocument::mAutoSize with various test cases here in this bug.
Assignee | ||
Comment 1•2 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=cb885034be30bd5e989dbc9891c3dcb99aea0348
Assignee | ||
Comment 2•2 years ago
|
||
This is a follow-up fix for bug 1431601, I didn't notice that we constrain mMaxZoom in here nsViewport class. In bug 1431601, instead we did constrain the value in nsIDocument::GetViewportInfo since the contrained value is used in the function.
Assignee | ||
Comment 3•2 years ago
|
||
It would be clear that |displayWidthChangeRatio| is set only in an |if (aForceAdjustResolution)| block. Depends on D9459
Assignee | ||
Comment 4•2 years ago
|
||
Following four conditions are where nsIDocument::mAutoSize is true and test cases for each condition. The conditions are the cases where we currently set nsIDocument::mAutoSize true in nsIDocument:GetViewportInfo. 1) width=device-width test_meta_viewport_auto_size_by_device_width.html 2) no width && height=device-height test_meta_viewport_auto_size_by_device_height.html 3) no width && initial-scale=1 test_meta_viewport_auto_size_by_fixed_height_and_initial_scale_1.html test_meta_viewport_auto_size_by_initial_scale_1.html 4) invalid width && (invalid height || no height) test_meta_viewport_auto_size_by_invalid_width.html Below tests are cases that autoSize is disabled. test_meta_viewport_auto_size_by_fixed_width_and_initial_scale_1.html test_meta_viewport_auto_size_by_fixed_width_and_device_height.html test_meta_viewport_auto_size_by_initial_scale_0_5.html test_meta_viewport_auto_size_by_invalid_width_and_fixed_height.html Depends on D9460
Assignee | ||
Comment 5•2 years ago
|
||
I guess we can eventually replace the conditions for autoSize with `width == nsViewportInfo::Auto` or `height == nsViewportInfo::Auto`, but it will break current behavior so for now we are going to preserve the current behavior. For example, we currently consider no viewport meta tag means autoSize is disabled but it should be an autoSize case. Depends on D9461
Updated•2 years ago
|
Attachment #9019212 -
Attachment is obsolete: true
Updated•2 years ago
|
Attachment #9019211 -
Attachment description: Bug 1501106 - Drop constain max zoom in nsViewportInfo. r=botond → Bug 1501106 - Drop constaint of max zoom in nsViewportInfo. r=botond
Pushed by hikezoe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/09f5387e2002 Drop constaint of max zoom in nsViewportInfo. r=botond https://hg.mozilla.org/integration/autoland/rev/e46f20ef7d4c Various test cases checking current autoSize behavior. r=botond https://hg.mozilla.org/integration/autoland/rev/40b1b00e610a Drop nsIDocument::mAutoSize and relevant members. r=botond
Updated•2 years ago
|
Attachment #9019211 -
Attachment description: Bug 1501106 - Drop constaint of max zoom in nsViewportInfo. r=botond → Bug 1501106 - Drop constraint of max zoom in nsViewportInfo. r=botond
Comment 7•2 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/09f5387e2002 https://hg.mozilla.org/mozilla-central/rev/e46f20ef7d4c https://hg.mozilla.org/mozilla-central/rev/40b1b00e610a
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in
before you can comment on or make changes to this bug.
Description
•