Closed Bug 1501109 Opened Last year Closed Last year

Simplify flexbox devtools growthState API to just report "growing" or "shrinking" for each line (never "unchanged")

Categories

(Core :: Layout: Block and Inline, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: dholbert, Assigned: bradwerth)

References

Details

Attachments

(2 files)

Spinning this off for the c++/webidl changes for bug 1501066.  See bug 1501066 comment 8.

Basically, we should:
 - assign growthState to "growing" or "shrinking" using the same check that we use to assign isUsingFlexGrow, here:
https://searchfox.org/mozilla-central/rev/fcfb479e6ff63aea017d063faa17877ff750b4e5/layout/generic/nsFlexContainerFrame.cpp#2642-2644
 - remove everything that messes with growthState below that.
 - remove all mentions of "unchanged"

And while we're at it, we might as well get rid of the ComputedFlexLineInfo::GrowthState enum type entirely, and just use mozilla::dom::FlexLineGrowthState.  i.e. we should just jump straight to the final type rather than doing this type-conversion:
https://searchfox.org/mozilla-central/rev/fcfb479e6ff63aea017d063faa17877ff750b4e5/dom/flex/FlexLineValues.cpp#33-43

Brad, I'll presumptuously set assignee=you to get this into your queue (to look at after bug 1498273 probably), though I'm also happy to take it as well if you'd prefer.
Pushed by bwerth@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/19472cba78cc
Part 1: Change Flex API growth state to match layout algorithm, and use enums from webidl. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/ec3c914d6136
Part 2: Update test expectations for flex line growth state. r=dholbert
https://hg.mozilla.org/mozilla-central/rev/19472cba78cc
https://hg.mozilla.org/mozilla-central/rev/ec3c914d6136
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.