1501145 - Assign default values to fields in nsColumnSet::ReflowConfig and nsColumnSet::ColumnBalanceData

Status: RESOLVED FIXED

(Core :: Layout: Columns, enhancement, P4)

Description

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

It might be good to assign good default values to those fields.

Comment 1

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1501145 Part 1 - Assign default values to ReflowConfig fields, and explicitly initialize them in ChooseColumnStrategy. r?mats

The original statement is neat, but one cannot easily associates the values
computed in ChooseColumnStrategy with the actually field name in ReflowConfig.

Remove the aFeasibleBSize and aInfeasibleBSize for ChooseColumnStrategy()
because they're not used.

Comment 2

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1501145 Part 2 - Assign default values to ColumnBalanceData fields. r?mats

Depends on D9467

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aa716a3cae86
Part 1 - Assign default values to ReflowConfig fields, and explicitly initialize them in ChooseColumnStrategy. r=mats
https://hg.mozilla.org/integration/autoland/rev/fb761199e41a
Part 2 - Assign default values to ColumnBalanceData fields. r=mats

Comment 4

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/aa716a3cae86
https://hg.mozilla.org/mozilla-central/rev/fb761199e41a