1501162 - shippingaddresschange redaction isn't compatible with jcrew.com

Status: NEW

(Core :: DOM: Web Payments, enhancement, P2)

Description

[Matthew N. [:MattN]]

function isAddressValid(a) {
  var d = globalObj.content.countryContext.toUpperCase(), // "US"
  c = 0 === a.recipient.length,
  b = a.country.toUpperCase(),
  e = 0 === a.postalCode.length,
  g = 0 === a.city.length;
  a = 0 === a.region.length;
  return c || 0 === b.length || e || g || a || b !== d ? !1 : !0
}

Since we redact the `recipient`, `isAddressValid` always returns `false` and therefore no shipping options are provided.

Does Webkit also redact the `recipient`? If so, should we reach out to j.crew to see if they can change this to not require the full address until the PaymentResponse is received?

Perhaps we can put the redaction behind a pref to ease user testing and in case it's not web compatible to ship.

Comment 1

[Matthew N. [:MattN]]

Also, since we no longer select the shipping address by default, maybe we can disable redaction?

Comment 2

[Yaron Tausky [:ytausky]]

Eden, how would you gauge this bug's priority?

Comment 3

[Matthew N. [:MattN]]

Note: Shopify.com also doesn't work with the redaction but I didn't look at which fields they require.

Comment 4

[Marcos Caceres [:marcosc]]

We obviously can't add the recipient:( I'll ask Andy what Apple does, but very much doubt they add recipient, given they redact everything else.

Comment 5

[Eden Chuang[:edenchuang]]

https://searchfox.org/mozilla-central/source/dom/payments/PaymentRequest.cpp#1075-1079

Comment 6

[Marcos Caceres [:marcosc]]

(In reply to Matthew N. [:MattN] (PM me if requests are blocking you) from comment #1)
> Also, since we no longer select the shipping address by default, maybe we
> can disable redaction?

I feel a somewhat strongly that we continue to redact until the user hits Pay. There is no reason for the merchant to get that information early - and it's surprising that so much would be shared with the merchant prior to someone committing to buy. 

We've reached out to other relevant parties for feedback - so let's sit on this for a little bit till we get a bit more info.