1501176 - rotate[XYZ]?(0deg) should interpolate with rotate[XYZ]?(__deg)

Status: RESOLVED FIXED

(Core :: CSS Transitions and Animations, enhancement, P3)

Description

[Brian Birtles (:birtles)]

See bug 1500820 comment 5.

Basically Chromium will allow interpolating something like rotate(0deg) with rotateX(360deg) by interpolating the angle rather than falling back to matrix interpolation.

The spec doesn't strictly allow this but it seems to match what authors would expect so we should update the spec and then do likewise in Gecko.

Comment 1

[Brian Birtles (:birtles)]

Filed spec issue for this: https://github.com/w3c/csswg-drafts/issues/3236

Comment 2

[Brian Birtles (:birtles)]

Alan Cutter made up some spec text for this:

  https://github.com/w3c/csswg-drafts/pull/3250

Comment 3

[Brian Birtles (:birtles)]

He even has some WIP tests (what a champ) -- but apparently they reveal even further differences in Gecko vs Blink :(

  https://github.com/alancutter/web-platform-tests/commit/2d25a0f6ac889cf3ee140057d5255ba9771f9706#diff-44fa4a5f6830eb8dcb8a4f9b848f43b9R89

Comment 4

[Brian Birtles (:birtles)]

I looked into the test failures, fixed a couple of mistaken tests, and dropped one that is probably related to bug 1499862.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=273ec83bb551b3df953e50486520f49173767d2d

Comment 5

[Brian Birtles (:birtles)]

Attachment: Bug 1501176 - Interpolate the angle between mis-matched rotate() functions when the angle of one is zero; r?hiro

As per forthcoming spec change:

  https://github.com/w3c/csswg-drafts/pull/3250

Comment 6

[Brian Birtles (:birtles)]

When this is ready to land, I plan to push the following test patch (written by Alan Cutter who has given me permission to land it with changes) too but Phabricator won't let me upload a patch on someone else's behalf:

  https://hg.mozilla.org/try/rev/b634297ab9ae209e7f380597395736032b7d33fc

Comment 7

[Brian Birtles (:birtles)]

Attachment: Tests patch

Comment 8

[Hiroyuki Ikezoe (:hiro)]

(In reply to Brian Birtles (:birtles) from comment #6)
> When this is ready to land, I plan to push the following test patch (written
> by Alan Cutter who has given me permission to land it with changes) too but
> Phabricator won't let me upload a patch on someone else's behalf:
> 
>   https://hg.mozilla.org/try/rev/b634297ab9ae209e7f380597395736032b7d33fc

Interesting, I did upload patches by Thomas Wisniewski before.  https://phabricator.services.mozilla.com/rMOZILLACENTRAL7d16ad1fa81ef1e0a441dcd912090e4e20f00a14

Comment 9

[Brian Birtles (:birtles)]

Yeah, I think the problem was that I am the reviewer of it and even though I set the patch author to Alan, Phabricator was treating me as the author. I got:

> ERR-CONDUIT-CORE: Validation errors:
>  - The author of a revision can not be a reviewer.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9ccb4ba13d95
Interpolate the angle between mis-matched rotate() functions when the angle of one is zero; r=hiro
https://hg.mozilla.org/integration/mozilla-inbound/rev/5bba3913b39b
Add tests for interpolating between mismatching rotate() functions where one has a zero angle; r=birtles

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/13783 for changes under testing/web-platform/tests

Comment 12

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 13

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/9ccb4ba13d95
https://hg.mozilla.org/mozilla-central/rev/5bba3913b39b

Comment 14

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged