Closed Bug 1501207 Opened 2 years ago Closed 2 years ago

The flex item sizing property section sometimes says that an item was "Set to grow" and "Not set to grow" at the same time

Categories

(DevTools :: Inspector, defect, P2)

defect

Tracking

(firefox65 fixed)

RESOLVED FIXED
Firefox 65
Tracking Status
firefox65 --- fixed

People

(Reporter: pbro, Assigned: pbro)

References

Details

Attachments

(1 file)

STR:
- open the following test case URL:
data:text/html,<div style="display:flex;width:500px;border:1px solid;"><span style="flex-grow:1;flex-basis:100px;max-width:50px;">item 1</span><span style="flex-grow:1">item 2</span></div>
- open the inspector
- select the first <span> flex item within the flex container

--> The flex item sizing property section says:

> There was extra room available on the flex line.
> Item was set to grow.
> Item was not set to grow.
> Item could not grow, siblings have likely used the extra space.

We should fix it so that it doesn't say that it was set *and* not set to grow at the same time.
See Also: → 1501066
As noted in bug 1501066, we have the same issue with "set to shrink" + "not set to shrink" being simultaneously reported for the same item.

(Addressing the "shrink" messaging might be out of scope for this bug, if you want to focus just on "set to grow" here for simplicity's sake.  Either way, I'm mentioning it here in case it influences any decisions around design/testcases/anything-else in preparation for fixing that other side of the issue.)
Thanks Daniel, I have seen that other bug you filed. I intend to look at that one next.
For now, I'm addressing these issues one by one, separately, but I have a feeling that at some stage, the whole "flexibility" logic of the flexbox inspector will need some refactoring. Not yet though.
Pushed by pbrosset@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c4123efb0536
Don't say that an item was both set and not set to grow; r=jdescottes
https://hg.mozilla.org/mozilla-central/rev/c4123efb0536
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
You need to log in before you can comment on or make changes to this bug.