1501261 - serialization of border-image-repeat and background-size doesn't match other browsers

Status: RESOLVED FIXED

(Core :: DOM: CSS Object Model, defect, P3)

Description

[Eric Willigers]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.67 Safari/537.36

Steps to reproduce:

Set background-size and border-image-repeat to "initial"
Read computed style
http://jsfiddle.net/ericwilligers/8pmvLant/



Actual results:

Property background-size has initial value "auto auto"
Property border-image-repeat has initial value "stretch stretch"




Expected results:

Property background-size has initial value "auto"
Property border-image-repeat has initial value "stretch"

These are the results that spec and Blink/Edge/Safari give.
https://drafts.csswg.org/css-backgrounds/#background-size
https://drafts.csswg.org/css-backgrounds/#border-image-repeat

Comment 1

[Timea Cernea [:tbabos][inactive]]

Hi Eric,

The issue can be reproduced on the latest Nightly 65.0a1 (2018-10-25), Firefox Beta 64.0b3 and Firefox Release 63.0 on Windows 10 x64 as well. Not sure if the component is the best one but feel free to move it if it is not.

Thanks for the report!

Comment 2

[Cameron McCormack (:heycam)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d4e620f9cf7b6f5f2caa57f13071d3381ead2213

Comment 3

[Cameron McCormack (:heycam)]

Looks like the repeated value should be omitted only if it's auto.

Comment 4

[Eric Willigers]

The repeated value for these two properties should be omitted if it is a keyword, not if it is a <length-percentage>.

Blink/Edge/Safari give the same results for
http://jsfiddle.net/ericwilligers/mo6ftn95/


> Looks like the repeated value should be omitted only if it's auto.

Correct for background-size.

Comment 5

[Cameron McCormack (:heycam)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=aef93483b70d15fc076d513d93d836a924819119

Comment 6

[Cameron McCormack (:heycam)]

Attachment: Bug 1501261 - Part 1: Use Servo to serialize border-image-repeat

With this change, all of Chrome, Edge, Firefox, and Safari serialize
border-image-repeat by omitting a repeated keyword, so we update a WPT
that was expecting duplicated keywords.

Comment 7

[Cameron McCormack (:heycam)]

Attachment: Bug 1501261 - Part 2: Serialize `background-size: auto auto` as "auto"

With this change, all of Chrome, Edge, Firefox, and Safari serialize
background-size by omitting the second "auto" if the value is "auto
auto".  Other keywords are still repeated.

Depends on D10445

Comment 8

[Cameron McCormack (:heycam)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3f8365ed10dbb0967349e4d8ed13775d4418d7f2

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4a37e18c3d3c
Part 1: Use Servo to serialize border-image-repeat r=firefox-style-system-reviewers,emilio
https://hg.mozilla.org/integration/autoland/rev/e63ddbf2a290
Part 2: Serialize `background-size: auto auto` as "auto" r=firefox-style-system-reviewers,emilio

Comment 10

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/13944 for changes under testing/web-platform/tests

Comment 11

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 12

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/4a37e18c3d3c
https://hg.mozilla.org/mozilla-central/rev/e63ddbf2a290

Comment 13

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged