1501459 - Remove Pocket mobile conversion tests no longer being used

Status: RESOLVED FIXED

(Firefox :: Pocket, enhancement)

Description

[Scott [:thecount] Downe]

There is a tests we ran, with three test variants, "show_prompt_preview", "show_prompt_no_preview", "show_prompt_get_app" plus the baseline.

We want to update it to only use "show_prompt_no_preview" and baseline, and remove any code dependent on "show_prompt_preview", and "show_prompt_get_app"

The code currently lives here:

https://searchfox.org/mozilla-central/source/browser/components/pocket

https://searchfox.org/mozilla-central/search?q=show_prompt_&case=false&regexp=false&path=

Comment 1

[Gavin Suntop [:gvn] (they/them)]

Attachment: Bug 1501459 - removing unused CTA layouts

Removing unused CTA layouts from multivariant testing for Pocket users without the mobile app installed.

Comment 2

[Gavin Suntop [:gvn] (they/them)]

This probably shouldn't land before https://getpocket.atlassian.net/browse/P18-2137 is closed.

Comment 3

[Gavin Suntop [:gvn] (they/them)]

(It should work without it, but would be good to verify against it.)

Comment 4

[Gavin Suntop [:gvn] (they/them)]

Backend PR: https://github.com/Pocket/Web/pull/1826

Comment 5

[Gavin Suntop [:gvn] (they/them)]

https://getpocket.atlassian.net/browse/P18-2137 is closed

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

Backed out changeset efd80121bf41 (Bug 1501459) for ES lint failure.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=efd80121bf41749353ea5b11fc7920a23510c8b5

Backout link: https://hg.mozilla.org/integration/autoland/rev/a799f209a66e93f584093a4f6d141266a2df6f7c

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=208449808&repo=autoland&lineNumber=269

[task 2018-10-29T19:26:10.279Z] creating build
[task 2018-10-29T19:26:10.279Z] creating build/temp.linux-x86_64-2.7
[task 2018-10-29T19:26:10.279Z] creating build/temp.linux-x86_64-2.7/psutil
[task 2018-10-29T19:26:10.279Z] x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fno-strict-aliasing -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -fPIC -DPSUTIL_POSIX=1 -DPSUTIL_VERSION=543 -DPSUTIL_LINUX=1 -I/usr/include/python2.7 -c psutil/_psutil_common.c -o build/temp.linux-x86_64-2.7/psutil/_psutil_common.o
[task 2018-10-29T19:26:10.279Z] x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fno-strict-aliasing -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -fPIC -DPSUTIL_POSIX=1 -DPSUTIL_VERSION=543 -DPSUTIL_LINUX=1 -I/usr/include/python2.7 -c psutil/_psutil_posix.c -o build/temp.linux-x86_64-2.7/psutil/_psutil_posix.o
[task 2018-10-29T19:26:10.279Z] x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fno-strict-aliasing -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -fPIC -DPSUTIL_POSIX=1 -DPSUTIL_VERSION=543 -DPSUTIL_LINUX=1 -I/usr/include/python2.7 -c psutil/_psutil_linux.c -o build/temp.linux-x86_64-2.7/psutil/_psutil_linux.o
[task 2018-10-29T19:26:10.279Z] creating build/lib.linux-x86_64-2.7
[task 2018-10-29T19:26:10.279Z] creating build/lib.linux-x86_64-2.7/psutil
[task 2018-10-29T19:26:10.279Z] x86_64-linux-gnu-gcc -pthread -shared -Wl,-O1 -Wl,-Bsymbolic-functions -Wl,-Bsymbolic-functions -Wl,-z,relro -fno-strict-aliasing -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -Wl,-Bsymbolic-functions -Wl,-z,relro -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security build/temp.linux-x86_64-2.7/psutil/_psutil_common.o build/temp.linux-x86_64-2.7/psutil/_psutil_posix.o build/temp.linux-x86_64-2.7/psutil/_psutil_linux.o -o build/lib.linux-x86_64-2.7/psutil/_psutil_linux.so
[task 2018-10-29T19:26:10.279Z] building 'psutil._psutil_posix' extension
[task 2018-10-29T19:26:10.279Z] x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fno-strict-aliasing -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -fPIC -DPSUTIL_POSIX=1 -DPSUTIL_VERSION=543 -DPSUTIL_LINUX=1 -I/usr/include/python2.7 -c psutil/_psutil_common.c -o build/temp.linux-x86_64-2.7/psutil/_psutil_common.o
[task 2018-10-29T19:26:10.279Z] x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fno-strict-aliasing -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -fPIC -DPSUTIL_POSIX=1 -DPSUTIL_VERSION=543 -DPSUTIL_LINUX=1 -I/usr/include/python2.7 -c psutil/_psutil_posix.c -o build/temp.linux-x86_64-2.7/psutil/_psutil_posix.o
[task 2018-10-29T19:26:10.279Z] x86_64-linux-gnu-gcc -pthread -shared -Wl,-O1 -Wl,-Bsymbolic-functions -Wl,-Bsymbolic-functions -Wl,-z,relro -fno-strict-aliasing -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -Wl,-Bsymbolic-functions -Wl,-z,relro -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security build/temp.linux-x86_64-2.7/psutil/_psutil_common.o build/temp.linux-x86_64-2.7/psutil/_psutil_posix.o -o build/lib.linux-x86_64-2.7/psutil/_psutil_posix.so
[task 2018-10-29T19:26:10.280Z] copying build/lib.linux-x86_64-2.7/psutil/_psutil_linux.so -> psutil
[task 2018-10-29T19:26:10.280Z] copying build/lib.linux-x86_64-2.7/psutil/_psutil_posix.so -> psutil
[task 2018-10-29T19:26:10.280Z] 
[task 2018-10-29T19:26:10.280Z] Error processing command. Ignoring because optional. (optional:packages.txt:comm/build/virtualenv_packages.txt)
[task 2018-10-29T19:30:46.034Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/browser/components/pocket/content/panels/js/sendtomobile.js:11:14 | '_swapPlaceholder' is defined but never used. (no-unused-vars)
[taskcluster 2018-10-29 19:30:46.668Z] === Task Finished ===

Comment 7

[Scott [:thecount] Downe]

Sorry about that, we fixed it up in the original phabricator link, should be passing lint now.

Try push is here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7562dcb082c2baf1b8f167f109463e9ab09a67ac

Which seems like it's good to go now.

Thanks!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b050bc66af60
removing unused CTA layouts r=thecount

Comment 9

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/b050bc66af60