1501605 - Update cubeb from upstream to 04d58b6

Status: RESOLVED FIXED

(Core :: Audio/Video: cubeb, defect, P2)

Description

[Alex Chronopoulos [:achronop]]

Pick commits:
04d58b6 osx: close the stream before calling setup (BMO 1500109)
262aea3 doc: update docs for register collection changed callback. Fixes 42

Comment 1

[Alex Chronopoulos [:achronop]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/73b5fa4feb449d10c332c24c8bbac7af8329c7d2
Bug 1501605 - Update cubeb from upstream to 04d58b6. r=kinetik

Comment 2

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/73b5fa4feb44

Comment 3

[Liz Henry (:lizzard) (relman/hg->git project)]

Alex, do you think we may want to uplift this to beta 64 since it fixed bug 1500109?

Comment 4

[Alex Chronopoulos [:achronop]]

Yes we need to uplift it, I have been waiting the fix to be baked on Nightly.

Comment 5

[Alex Chronopoulos [:achronop]]

NI to myself for the uplift.

Comment 6

[Alex Chronopoulos [:achronop]]

Attachment: uplift-cubeb-04d58b6-to-beta.patch

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Bug 1501605

User impact if declined: A sporadic crash when a user join a webrtc call with BT headset

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: Yes

Needs manual test from QE?: No

If yes, steps to reproduce: 

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): It works well in Nightly. Also, it's a small fix (one line).

String changes made/needed:

Comment 7

[Ryan VanderMeulen [:RyanVM]]

(In reply to Alex Chronopoulos [:achronop] from comment #6)
> Feature/Bug causing the regression: Bug 1501605

That's this bug. Can you please clarify which bug you meant to say?

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9020724 [details] [diff] [review]
uplift-cubeb-04d58b6-to-beta.patch

[Triage Comment]
Fixes webrtc crashes while using a BT headset. Approved for 64.0b5.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/08d5049ad5d9

Comment 10

[Alex Chronopoulos [:achronop]]

I meant to say Bug 1500109. Thanks

Comment 11

[Ryan VanderMeulen [:RyanVM]]

That still doesn't make sense. That's the bug this uplift is *fixing*. The question on the form is which bug *caused* the problem.

Comment 12

[Alex Chronopoulos [:achronop]]

The problem caused by Bug 1489052.

Comment 13

[Alex Chronopoulos [:achronop]]

Hmm this does not look right, I think you have uplifted the original patch and not the one nominated for uplift. This is totally fine from runtime execution point of view but it creates confusion in the way we mark changes in this folder. Is it late to backout and re-land the correct one?

I am putting off the uplift request of Bug 1503240 since it will go on the top of that.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Backed out:
https://hg.mozilla.org/releases/mozilla-beta/rev/84baa2ea8fe2
Relanded:
https://hg.mozilla.org/releases/mozilla-beta/rev/1ca9702a4960

Comment 15

[Cornel Ionce [:noni] [Hubs QA]]

Marking as qe- per comment#6