1501623 - UrlbarInput::setValueFromResult should set userTypedValue

Status: RESOLVED FIXED

(Firefox :: Address Bar, enhancement, P2)

Description

[Dão Gottwald [:dao]]

autocomplete.xml does this:

https://searchfox.org/mozilla-central/rev/fcfb479e6ff63aea017d063faa17877ff750b4e5/toolkit/content/widgets/autocomplete.xml#197-203

This goes back to bug 287996.

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1501623 - Set userTypedValue from setValueFromResult. r=adw

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b7597732606e
Dispatch an input event from UrlbarInput::setValueFromResult. r=adw

Comment 3

[Raul Gurzau (:RaulG)]

Backed out changeset b7597732606e (bug 1501623)for failing at browser_autocomplete_edit_completed.js on a CLOSED TREE.

Backout link: https://hg.mozilla.org/integration/autoland/rev/e2780a098404114db5aea796c87e577ce2c54f05

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=b7597732606e96cd3337c316b5771ae09e9b8ab9&selectedJob=225570500

Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=225570500&repo=autoland&lineNumber=5579

Log snippet:

[task 2019-02-02T00:33:19.628Z] 00:33:19 INFO - TEST-START | browser/components/urlbar/tests/browser/browser_autocomplete_edit_completed.js
[task 2019-02-02T00:33:20.316Z] 00:33:20 INFO - TEST-INFO | started process screentopng
[task 2019-02-02T00:33:20.748Z] 00:33:20 INFO - TEST-INFO | screentopng: exit 0
[task 2019-02-02T00:33:20.749Z] 00:33:20 INFO - Buffered messages logged at 00:33:19
[task 2019-02-02T00:33:20.751Z] 00:33:20 INFO - Entering test bound
[task 2019-02-02T00:33:20.752Z] 00:33:20 INFO - Buffered messages logged at 00:33:20
[task 2019-02-02T00:33:20.753Z] 00:33:20 INFO - Key Down to select the next item.
[task 2019-02-02T00:33:20.754Z] 00:33:20 INFO - Buffered messages finished
[task 2019-02-02T00:33:20.755Z] 00:33:20 INFO - TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/browser/browser_autocomplete_edit_completed.js | Uncaught exception - at resource:///modules/UrlbarUtils.jsm:246 - TypeError: result is undefined
[task 2019-02-02T00:33:20.757Z] 00:33:20 INFO - Stack trace:
[task 2019-02-02T00:33:20.759Z] 00:33:20 INFO - getUrlFromResult@resource:///modules/UrlbarUtils.jsm:246:5
[task 2019-02-02T00:33:20.760Z] 00:33:20 INFO - getDetailsOfResultAt@resource://testing-common/UrlbarTestUtils.jsm:309:22
[task 2019-02-02T00:33:20.761Z] 00:33:20 INFO - asyncgetDetailsOfResultAt@resource://testing-common/UrlbarTestUtils.jsm:81:12
[task 2019-02-02T00:33:20.763Z] 00:33:20 INFO - async@chrome://mochitests/content/browser/browser/components/urlbar/tests/browser/browser_autocomplete_edit_completed.js:30:26
[task 2019-02-02T00:33:20.763Z] 00:33:20 INFO - AsyncTester_execTest/<@chrome://mochikit/content/browser-test.js:1106:34
[task 2019-02-02T00:33:20.766Z] 00:33:20 INFO - asyncTester_execTest@chrome://mochikit/content/browser-test.js:1097:16
[task 2019-02-02T00:33:20.767Z] 00:33:20 INFO - nextTest/<@chrome://mochikit/content/browser-test.js:995:9
[task 2019-02-02T00:33:20.769Z] 00:33:20 INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:803:59
[task 2019-02-02T00:33:20.771Z] 00:33:20 INFO - Leaving test bound
[task 2019-02-02T00:33:20.772Z] 00:33:20 INFO - GECKO(7346) | MEMORY STAT | vsize 681MB | residentFast 315MB | heapAllocated 137MB
[task 2019-02-02T00:33:20.773Z] 00:33:20 INFO - TEST-OK | browser/components/urlbar/tests/browser/browser_autocomplete_edit_completed.js | took 811ms
[task 2019-02-02T00:33:20.774Z] 00:33:20 INFO - checking window state

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dbda94af3d52
Set userTypedValue from setValueFromResult. r=adw

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/dbda94af3d52