Open Bug 1501760 Opened 7 years ago Updated 1 year ago

Intermittent devtools/client/inspector/grids/test/browser_grids_grid-outline-highlight-area.js | Test timed out -

Categories

(DevTools :: Inspector, defect, P5)

defect

Tracking

(Not tracked)

People

(Reporter: intermittent-bug-filer, Unassigned)

References

Details

(Keywords: intermittent-failure, leave-open, Whiteboard: [stockwell disabled][stockwell unknown])

Attachments

(3 files)

This test was added more than a year ago and was running fine until recently. Started to fail very seldomly about a month ago, and now much more for the past 2 weeks. There hasn't been any changes made to the test that would explain this. The test seems to be failing only on Windows debug and asan (slow environments), and as far as I can see, the test times out while waiting for the grid-highlighter-shown event. This event never seems to be fired, so the test just ends up waiting until it times out. Micah, when you get a chance, could you please take a quick look at this one? It might be hard to reproduce locally, but since you originally worked on it, maybe an idea comes to mind as to what could be the problem here.
Flags: needinfo?(mtigley)
Thanks Patrick, I'll take a look.
Flags: needinfo?(mtigley)
Attachment #9033089 - Flags: review?(jmaher)
Attachment #9033089 - Flags: review?(jmaher) → review+
Whiteboard: [stockwell disable-recommended] → [stockwell disabled]
Pushed by csabou@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/585bf4f080f9 Disable browser_grids_grid-outline-highlight-area.js on win10 for frequent failures. r=jmaher
Keywords: checkin-needed

Clearing need info for now since I'm not actively investigating this.

Flags: needinfo?(mtigley)

There are 32 total failures in the last 7 days on

task 2021-06-27T02:03:17.914Z] 02:03:17 INFO - TEST-START | devtools/client/inspector/grids/test/browser_grids_grid-outline-highlight-area.js
[task 2021-06-27T02:03:17.972Z] 02:03:17 INFO - GECKO(6317) | [Parent 6317: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 139496000 == 7 [pid = 6317] [id = 64] [url = chrome://devtools/content/inspector/markup/markup.xhtml]
[task 2021-06-27T02:03:17.972Z] 02:03:17 INFO - GECKO(6317) | [Parent 6317: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 1302f5c00 == 6 [pid = 6317] [id = 62] [url = about:devtools-toolbox]
[task 2021-06-27T02:03:17.974Z] 02:03:17 INFO - GECKO(6317) | [Child 6328: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 10641e400 == 2 [pid = 6328] [id = 22]
[task 2021-06-27T02:03:17.974Z] 02:03:17 INFO - GECKO(6317) | [Child 6328: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 4 (106487040) [pid = 6328] [serial = 66] [outer = 0]
[task 2021-06-27T02:03:17.975Z] 02:03:17 INFO - GECKO(6317) | [Child 6328: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 5 (106421400) [pid = 6328] [serial = 67] [outer = 106487040]
[task 2021-06-27T02:03:17.995Z] 02:03:17 INFO - GECKO(6317) | [Child 6328: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 6 (106519c00) [pid = 6328] [serial = 68] [outer = 106487040]
[task 2021-06-27T02:03:18.063Z] 02:03:18 INFO - GECKO(6317) | [Parent 6317: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 12c053400 == 7 [pid = 6317] [id = 65]
[task 2021-06-27T02:03:18.064Z] 02:03:18 INFO - GECKO(6317) | [Parent 6317: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 21 (11610a200) [pid = 6317] [serial = 151] [outer = 0]
[task 2021-06-27T02:03:18.065Z] 02:03:18 INFO - GECKO(6317) | [Parent 6317: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 22 (133f56400) [pid = 6317] [serial = 152] [outer = 11610a200]
[task 2021-06-27T02:03:18.081Z] 02:03:18 INFO - GECKO(6317) | [Child 6328, Main Thread] WARNING: Scrolled rect smaller than scrollport?: file /builds/worker/checkouts/gecko/layout/generic/nsGfxScrollFrame.cpp:7051
[task 2021-06-27T02:03:18.099Z] 02:03:18 INFO - GECKO(6317) | [Parent 6317: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 23 (12ae04400) [pid = 6317] [serial = 153] [outer = 11610a200]
[task 2021-06-27T02:03:18.154Z] 02:03:18 INFO - GECKO(6317) | [Parent 6317, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005 (NS_ERROR_FAILURE): file /builds/worker/checkouts/gecko/dom/base/nsContentUtils.cpp:4017
[task 2021-06-27T02:03:18.292Z] 02:03:18 INFO - GECKO(6317) | [Parent 6317: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 132a51000 == 8 [pid = 6317] [id = 66]
[task 2021-06-27T02:03:18.293Z] 02:03:18 INFO - GECKO(6317) | [Parent 6317: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 24 (11610a580) [pid = 6317] [serial = 154] [outer = 0]
[task 2021-06-27T02:03:18.293Z] 02:03:18 INFO - GECKO(6317) | [Parent 6317: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 25 (13519fc00) [pid = 6317] [serial = 155] [outer = 11610a580]
[task 2021-06-27T02:03:18.304Z] 02:03:18 INFO - GECKO(6317) | [Parent 6317, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005 (NS_ERROR_FAILURE): file /builds/worker/checkouts/gecko/chrome/nsChromeRegistry.cpp:180
[task 2021-06-27T02:03:18.304Z] 02:03:18 INFO - GECKO(6317) | [Parent 6317, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005 (NS_ERROR_FAILURE): file /builds/worker/checkouts/gecko/dom/security/nsCSPService.cpp:191
[task 2021-06-27T02:03:18.912Z] 02:03:18 INFO - GECKO(6317) | [Parent 6317: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 138e83000 == 9 [pid = 6317] [id = 67]
[task 2021-06-27T02:03:18.912Z] 02:03:18 INFO - GECKO(6317) | [Parent 6317: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 26 (117671e40) [pid = 6317] [serial = 156] [outer = 0]
[task 2021-06-27T02:03:18.913Z] 02:03:18 INFO - GECKO(6317) | [Parent 6317: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 27 (13a310c00) [pid = 6317] [serial = 157] [outer = 117671e40]
[task 2021-06-27T02:03:18.923Z] 02:03:18 INFO - GECKO(6317) | [Parent 6317, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005 (NS_ERROR_FAILURE): file /builds/worker/checkouts/gecko/chrome/nsChromeRegistry.cpp:180
[task 2021-06-27T02:03:18.924Z] 02:03:18 INFO - GECKO(6317) | [Parent 6317, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005 (NS_ERROR_FAILURE): file /builds/worker/checkouts/gecko/dom/security/nsCSPService.cpp:191
[task 2021-06-27T02:03:19.031Z] 02:03:19 INFO - GECKO(6317) | console.log: "[DISPATCH] action type:" "CLEAR_FLEXBOX"
[task 2021-06-27T02:03:19.123Z] 02:03:19 INFO - GECKO(6317) | console.log: "[DISPATCH] action type:" "UPDATE_GRIDS"

[task 2021-06-27T02:04:47.965Z] 02:04:47 INFO - TEST-INFO | started process screencapture
[task 2021-06-27T02:04:48.082Z] 02:04:48 INFO - TEST-INFO | screencapture: exit 0
[task 2021-06-27T02:04:48.082Z] 02:04:48 INFO - Buffered messages logged at 02:03:17
[task 2021-06-27T02:04:48.083Z] 02:04:48 INFO - Entering test bound
[task 2021-06-27T02:04:48.084Z] 02:04:48 INFO - Adding a new tab with URL: data:text/html;charset=utf-8,%0A%20%20%3Cstyle%20type%3D'text%2Fcss'%3E%0A%20%20%20%20%23grid%20%7B%0A%20%20%20%20%20%20display%3A%20grid%3B%0A%20%20%20%20%20%20grid-template-areas%3A%0A%20%20%20%20%20%20%20%20%22header%22%0A%20%20%20%20%20%20%20%20%22footer%22%3B%0A%20%20%20%20%7D%0A%20%20%20%20.top%20%7B%0A%20%20%20%20%20%20grid-area%3A%20header%3B%0A%20%20%20%20%7D%0A%20%20%20%20.bottom%20%7B%0A%20%20%20%20%20%20grid-area%3A%20footer%3B%0A%20%20%20%20%7D%0A%20%20%3C%2Fstyle%3E%0A%20%20%3Cdiv%20id%3D%22grid%22%3E%0A%20%20%20%20%3Cdiv%20id%3D%22cella%22%20className%3D%22top%22%3ECell%20A%3C%2Fdiv%3E%0A%20%20%20%20%3Cdiv%20id%3D%22cellb%22%20className%3D%22bottom%22%3ECell%20B%3C%2Fdiv%3E%0A%20%20%3C%2Fdiv%3E%0A
[task 2021-06-27T02:04:48.084Z] 02:04:48 INFO - Buffered messages logged at 02:03:18
[task 2021-06-27T02:04:48.085Z] 02:04:48 INFO - Tab added and finished loading
[task 2021-06-27T02:04:48.085Z] 02:04:48 INFO - Opening the inspector
[task 2021-06-27T02:04:48.086Z] 02:04:48 INFO - Opening the toolbox
[task 2021-06-27T02:04:48.086Z] 02:04:48 INFO - Console message: Invalid chrome URI (need path): chrome://devtools/
[task 2021-06-27T02:04:48.086Z] 02:04:48 INFO - Console message: Invalid chrome URI (need path): chrome://devtools/
[task 2021-06-27T02:04:48.087Z] 02:04:48 INFO - Buffered messages logged at 02:03:19
[task 2021-06-27T02:04:48.087Z] 02:04:48 INFO - Toolbox opened and focused
[task 2021-06-27T02:04:48.088Z] 02:04:48 INFO - Selecting the layoutview sidebar
[task 2021-06-27T02:04:48.088Z] 02:04:48 INFO - Toggling ON the CSS grid highlighter from the layout panel.
[task 2021-06-27T02:04:48.088Z] 02:04:48 INFO - Waiting for state predicate "state => state.grids.length == 1 && state.grids[0].highlighted"
[task 2021-06-27T02:04:48.089Z] 02:04:48 INFO - Found state predicate "state => state.grids.length == 1 && state.grids[0].highlighted"
[task 2021-06-27T02:04:48.089Z] 02:04:48 INFO - Hovering over grid cell A in the grid outline.
[task 2021-06-27T02:04:48.089Z] 02:04:48 INFO - Buffered messages finished
[task 2021-06-27T02:04:48.090Z] 02:04:48 INFO - TEST-UNEXPECTED-FAIL | devtools/client/inspector/grids/test/browser_grids_grid-outline-highlight-area.js | Test timed out -
[task 2021-06-27T02:04:48.726Z] 02:04:48 INFO - Removing tab.
[task 2021-06-27T02:04:48.726Z] 02:04:48 INFO - Waiting for event: 'TabClose' on [object XULElement].
[task 2021-06-27T02:04:48.748Z] 02:04:48 INFO - Got event: 'TabClose' on [object XULElement].
[task 2021-06-27T02:04:48.763Z] 02:04:48 INFO - GECKO(6317) | [Parent 6317, Main Thread] WARNING: '!inner', file /builds/worker/checkouts/gecko/dom/ipc/jsactor/JSWindowActorProtocol.cpp:184
[task 2021-06-27T02:04:48.767Z] 02:04:48 INFO - Tab removed and finished closing
[task 2021-06-27T02:04:48.797Z] 02:04:48 INFO - TEST-PASS | devtools/client/inspector/grids/test/browser_grids_grid-outline-highlight-area.js | The main process DevToolsServer has no pending connection when the test ends -
[task 2021-06-27T02:04:48.804Z] 02:04:48 INFO - GECKO(6317) | [Parent 6317: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 132a51000 == 7 [pid = 6317] [id = 66] [url = chrome://devtools/content/inspector/index.xhtml]
[task 2021-06-27T02:04:48.804Z] 02:04:48 INFO - GECKO(6317) | [Parent 6317: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 138e83000 == 6 [pid = 6317] [id = 67] [url = chrome://devtools/content/inspector/markup/markup.xhtml]
[task 2021-06-27T02:04:48.809Z] 02:04:48 INFO - GECKO(6317) | MEMORY STAT | vsize 9404MB | residentFast 388MB | heapAllocated 127MB
[task 2021-06-27T02:04:48.810Z] 02:04:48 INFO - TEST-OK | devtools/client/inspector/grids/test/browser_grids_grid-outline-highlight-area.js | took 90897ms
[task 2021-06-27T02:04:48.819Z] 02:04:48 INFO - GECKO(6317) | [Child 6327: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 10800b400 == 1 [pid = 6327] [id = 11]
[task 2021-06-27T02:04:48.820Z] 02:04:48 INFO - GECKO(6317) | [Child 6327: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 1 (107fc9c80) [pid = 6327] [serial = 24] [outer = 0]
[task 2021-06-27T02:04:48.820Z] 02:04:48 INFO - GECKO(6317) | [Child 6327: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 2 (108013800) [pid = 6327] [serial = 25] [outer = 107fc9c80]
[task 2021-06-27T02:04:48.843Z] 02:04:48 INFO - checking window state

Julian, can you please take a look?

Flags: needinfo?(jdescottes)
Whiteboard: [stockwell disabled] → [stockwell disabled][stockwell needswork:owner]

It seems that from time to time, we get an extra reflow when the inspector starts and the "grid inspector item" we attempt to hover is being re-rendered while we call:

  EventUtils.synthesizeMouseAtCenter(
    gridCellA,
    { type: "mouseover" },
    doc.defaultView
  );

gridCellA is the response to an async call to waitForDOM, but before using it we actually wait for a bunch of other events (onCheckboxChange, onHighlighterShown), so there are lots of opportunities to get an intermediary render.

An easy fix should be to fetch a fresh copy of the element we want to hover before calling synthesizeMouseAtCenter.
At least it fixes it for me locally.

Flags: needinfo?(jdescottes)

Going to apply the same fix on the similar test (browser_grids_grid-outline-highlight-cell.js) tracked by Bug 1501317.

Depends on D118894

Not completely convinced but the two tests are almost identical. Seems like a mess to maintain those 2 identical copies.

Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0aed4ca3ab31 [devtools] Fix intermittent failures in grid tests using stale elements for mouseover r=nchevobbe
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: