Closed Bug 1501904 Opened 3 years ago Closed 2 years ago
Emacs-like shortcuts in Mac location bar should fire accessibility focus events
47 bytes, text/x-phabricator-request
|Details | Review|
Spun off bug 1389221 comment 19. Bug 1389221 implemented Emacs-like keys (control+n/control+p) for the location bar on Mac. Accessibility events won't be fired correctly when these keys are used. I fixed this behaviour for the up/down arrow keys and page up/down in bug 1331755, but there's going to need to be an additional tweak to handle these new keys. The handling for the arrow/page keys is here: https://searchfox.org/mozilla-central/source/browser/base/content/urlbarBindings.xml#322 There's also an accessibility test for the URL bar which should be updated (with a Mac specific check for this bit): https://searchfox.org/mozilla-central/source/accessible/tests/browser/events/browser_test_focus_urlbar.js I don't have a Mac to test this, but Ross confirmed my suspicion. STR should be something like this: 1. Start VoiceOver. 2. Focus the location bar. 3. Type some text. 4. Press control+n to move to the next suggestion. Expected: VoiceOver should read the active autocomplete suggestion. Actual: It doesn't.
(In reply to James Teh [:Jamie] from comment #0) > I don't have a Mac to test this, but Ross confirmed my suspicion. STR should > be something like this: > 1. Start VoiceOver. > 2. Focus the location bar. > 3. Type some text. > 4. Press control+n to move to the next suggestion. > Expected: VoiceOver should read the active autocomplete suggestion. > Actual: It doesn't. Just to confirm: yes, these are the steps to reproduce (you can easily "focus the location bar" by opening a new window). I plan to do the work to fix this, but it'll be a couple days before I get to it.
Is this patch ready to land?
(In reply to Dão Gottwald [::dao] from comment #3) > Is this patch ready to land? If it looks good to you after my most recent change, then yes!
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/f6eef4da9862 Fire accessibility focus events when using readline nav in url bar r=dao,Jamie
You need to log in before you can comment on or make changes to this bug.