1501909 - JSON viewer color update 65.0a1, feature or bug?

Status: RESOLVED FIXED

(DevTools :: JSON Viewer, defect, P2)

Description

[FansubTH.001]

Attachment: FF Nightly.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/69.0.3497.100 Safari/537.36

Steps to reproduce:

Open the JSON file


Actual results:

All text color blue it's hard to read, not the same as the previous version.

See image the text "th" should be purple color > https://imgur.com/a/J1Vgf9e


Expected results:

See image the text "th" should be a purple color like the previous version. > https://imgur.com/a/J1Vgf9e

Comment 1

[Matthias Versen [:Matti]]

most likely caused by bug 1494789

 1:49.80 INFO: Last good revision: 6e96c7ec0d1187c1b488dd4ba645df9cfd68ec16
 1:49.80 INFO: First bad revision: eea979fe8a920693df4859d22fad5c8098a57569
 1:49.80 INFO: Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=6e96c7ec0d1187c1b488dd4ba645df9cfd68ec16&tochange=eea979fe8a920693df4859d22fad5c8098a57569

Comment 2

[Kristin Taylor [:kristin]]

Thanks! I'll work on this over the weekend.

Comment 3

[Oriol Brufau [:Oriol]]

(In reply to Kristin Taylor [:kristin] from comment #2)
> Thanks! I'll work on this over the weekend.

You used var(--error-color) in reps.css, but --error-color is defined in webconsole.css
The JSON Viewer is a consumer of reps.css but not webconsole.css

Comment 4

[Jan Honza Odvarko [:Honza] (always need-info? me)]

(In reply to Kristin Taylor [:kristin] from comment #2)
> Thanks! I'll work on this over the weekend.
Thanks, assigned to you

Honza

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

I think it was accidentally fixed by Bug 1502224. Text is back to purple for me now on 65.0a1 (2018-10-30).
FansubTH.001 , could you confirm this?

Comment 6

[Matthias Versen [:Matti]]

I can confirm that this seems to be fixed in the latest nightly