Closed Bug 1501979 Opened 3 years ago Closed 3 years ago

PerformanceObserver doesn't traverse its mQueuedEntries

Categories

(Core :: DOM: Core & HTML, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: jonco, Assigned: jonco)

References

Details

Attachments

(1 file)

I don't know how these objects are used but PerformanceEntry is a cycle collected class so I think PerformanceObserver needs to traverse its mQueuedEntries array of these.
Attachment #9019966 - Flags: review?(continuation)
Assignee: nobody → jcoppeard
Priority: -- → P2
Shouldn't it clear the queued entries automatically at some point.
Comment on attachment 9019966 [details] [diff] [review]
performance-observer

Review of attachment 9019966 [details] [diff] [review]:
-----------------------------------------------------------------

Seems reasonable. DOMIntersectionObserver has a field with the same name and it does report it to the CC.
Attachment #9019966 - Flags: review?(continuation) → review+
Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3239cb300fdb
Make PerformanceObserver report mQueuedEntries to the cycle collector r=mccr8
https://hg.mozilla.org/mozilla-central/rev/3239cb300fdb
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
No longer blocks: 1519676
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.