1502082 - Pasting in the "Card Number" field will display all the suggestions

Status: RESOLVED WONTFIX

(Toolkit :: Form Autofill, defect, P1)

Description

[Hani Yacoub, Desktop QA]

[Affected versions]: 
Nightly 65.0a1 (2018-10-25)

[Affected platforms]:
Platforms: Windows 10 x 64, Mac OS 10.13, Ubuntu 16.04.

[Preconditions]:
1. Go to Preferences(Options)/ Privacy and Security / Form Autofill / Enable Saved Credit Cards
2. extensions.formautofill.creditCards.enabled set to "true"


[Steps to reproduce]:
1. Make sure you have a couple of CC numbers saved.
2. Go to "https://luke-chang.github.io/autofill-demo/basic_cc.html".
3. Copy any card number (e.g 4504284330884621).
4. Paste it in the "Card Number" field.

[Expected result]:
CC number should be pasted, without displaying all the suggestions.

[Actual result]:
Pasting in the "Card Number" field will display all the suggestions.

[Note]:
I did a regression range and here are the results:
Last good revision: 69d881a7866706d50389e433904d5946106e42d1
First bad revision: 740ead88dd207c38155800e176c693987a762d2d
Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=69d881a7866706d50389e433904d5946106e42d1&tochange=740ead88dd207c38155800e176c693987a762d2d

Comment 1

[Matthew N. [:MattN]]

Tim, I guess this is a case where we chose the non-MP path but I think we should have chosen the other path since this defeats teh re-authentication by revealing the user's card info by just typing a prefix e.g. 450. Would you have time to fix this?

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Attachment: image.png

(In reply to Matthew N. [:MattN] (PM me if requests are blocking you) from comment #1)
> Tim, I guess this is a case where we chose the non-MP path but I think we
> should have chosen the other path since this defeats teh re-authentication
> by revealing the user's card info by just typing a prefix e.g. 450. Would
> you have time to fix this?

I am slightly confused. So the current behavior *avoids* revealing the user's card info by listing all the card saved. If we took another route and decide to filter the suggestion list, only the card matching the prefix will be shown.

In this example, two cards are shown even though the first one starts with 4111.

WONTFIX?

Comment 3

[Matthew N. [:MattN]]

Oh, sorry, yeah, let's WONTFIX for now. We can change our mind later if the dropdown is too distracting… though I would question why the user didn't use autofill in the first place…