1502118 - Audit and assert thread assumptions

Status: RESOLVED FIXED

(GeckoView :: General, enhancement, P2)

Description

[[ex-Mozilla] Agi Sferro | :agi]

This bug is about adding thread assumption asserts like `ThreadUtils.assertOnUiThread` to every GeckoView API that assumes to be called in a specific thread (See also parent Bug 1500456).

Comment 1

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1502118 - Add @UiThread to methods that call assertOnUiThread. r?snorp.

Comment 2

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1502118 - Add assertOnUiThread calls to GeckoDisplay. r?droeh,snorp.

Depends on D10237

Comment 3

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1502118 - Fix threading documentation on GeckoResult. r?snorp.

Depends on D10238

Comment 4

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1502118 - Add @AnyThread to APIs that can be used from any thread. r?snorp.

This patch adds @AnyThread to any API that can be explicitely called from any
thread.

Depends on D10239

Comment 5

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1502118 - Add @UiThread to GeckoSession.TextInputDelegate. r?snorp.

Depends on D10240

Comment 6

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1502118 - Call assertOnUiThread in GeckoView. r?snorp.

Depends on D10241

Comment 7

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1502118 - Call assertOnUiThread in SessionAccessibility. r?eeejay.

Depends on D10242

Comment 8

[[ex-Mozilla] Agi Sferro | :agi]

try https://treeherder.mozilla.org/#/jobs?repo=try&revision=f2580156322ffa1bc28036963f929ff69d0f66e4

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/93c80c846adb
Add @UiThread to methods that call assertOnUiThread. r=snorp.
https://hg.mozilla.org/integration/autoland/rev/c3437e254961
Add assertOnUiThread calls to GeckoDisplay. r=snorp,droeh.
https://hg.mozilla.org/integration/autoland/rev/f38363e53ca4
Fix threading documentation on GeckoResult. r=snorp.
https://hg.mozilla.org/integration/autoland/rev/aed3a7740a86
Add @AnyThread to APIs that can be used from any thread. r=snorp.
https://hg.mozilla.org/integration/autoland/rev/c26e3232d3a3
Add @UiThread to GeckoSession.TextInputDelegate. r=snorp.
https://hg.mozilla.org/integration/autoland/rev/6434abf7d806
Call assertOnUiThread in GeckoView. r=snorp.
https://hg.mozilla.org/integration/autoland/rev/1b95e3c16503
Call assertOnUiThread in SessionAccessibility. r=eeejay.

Comment 10

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/93c80c846adb
https://hg.mozilla.org/mozilla-central/rev/c3437e254961
https://hg.mozilla.org/mozilla-central/rev/f38363e53ca4
https://hg.mozilla.org/mozilla-central/rev/aed3a7740a86
https://hg.mozilla.org/mozilla-central/rev/c26e3232d3a3
https://hg.mozilla.org/mozilla-central/rev/6434abf7d806
https://hg.mozilla.org/mozilla-central/rev/1b95e3c16503

Comment 11

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1502118 - Add @UiThread to all Delegate interfaces. r=snorp!,esawin!

Comment 12

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1502118 - Add threading annotations to remaining APIs. r=snorp!

Depends on D13880

Comment 13

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1502118 - Make FinderResult non-final for testing. r=snorp!,esawin!

This allows mocking for embedders.

Depends on D13881

Comment 14

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1502118 - Enforce GV lints with apilint. r=snorp!

This makes it so that apilints lints with "GV" codes are enforced and will fail
the build.

Depends on D13882

Comment 15

[[ex-Mozilla] Agi Sferro | :agi]

This last stack of patches will conclude the work for this bug, yay!

Try here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9f32d4e0389231fa2a07a9c4b7db490680d516b2

Comment 16

[[ex-Mozilla] Agi Sferro | :agi]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4f25307ab1edb32034e91ec9b9848f8dfcbf4e8b

Comment 17

[[ex-Mozilla] Agi Sferro | :agi]

New try with mochitest fix: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b2538689ca0e9495afe02e014f5b2e5528763892

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/95951162d775
Add @UiThread to all Delegate interfaces. r=snorp,esawin
https://hg.mozilla.org/integration/autoland/rev/0d938252d0ed
Add threading annotations to remaining APIs. r=snorp
https://hg.mozilla.org/integration/autoland/rev/4cd3b9cf8159
Make FinderResult non-final for testing. r=snorp,esawin
https://hg.mozilla.org/integration/autoland/rev/42f4f1c36ef6
Enforce GV lints with apilint. r=snorp

Comment 19

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/95951162d775
https://hg.mozilla.org/mozilla-central/rev/0d938252d0ed
https://hg.mozilla.org/mozilla-central/rev/4cd3b9cf8159
https://hg.mozilla.org/mozilla-central/rev/42f4f1c36ef6