1502121 - asyncReauthenticateUser throws NS_ERROR_FAILURE instead of returning false in non-exceptional circumstances

Status: RESOLVED WORKSFORME

(Core :: Security: PSM, defect)

Description

[Matthew N. [:MattN]]

ReauthenticateUserWindows should return NS_OK but with `reauthenticated = false` in non-exceptional cases so the promise resolves to `false`.

Some of the cases to fix:
* User cancels the dialog
* User enters an incorrect username/password combo.
* User enters a correct credential for a different user

On a related note, is there a way to get the dialog to allow the user to try again in the "incorrect username/password" case, like the macOS dialog does?

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

fwiw, oskeystore methods reject when the user cancels the login dialog.

It's fine if it is always rejected when the user cancels, but it's better if the behavior is consistent across platforms as described in the source code comments.

Comment 2

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Bug 1505197 should be taking care of this.

Comment 3

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Matt - can you check if this works the intended way as of bug 1505197?

Comment 4

[Matthew N. [:MattN]]

It's tedious to test all the cases on both OSs and I haven't been touching the re-auth code recently so let's just call this done for now until we see an issue.