1502159 - Assorted JIT Spew cleanup

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, enhancement, P3)

Description

[Matthew Gaudet (he/him) [:mgaudet]]

There's some cleanup that can be done in the JIT Spew files

Comment 1

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1502159 - Remove dead constant in JitSpewer.h r?IainIreland

Comment 2

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1502159 - Remove C1Spewer

It appears the C1 Spewer is not partciularly well used. Loading logs into
IRHydra [1] points out that the majority of phase dumps appear to be broken
except for LIR.


[1]: https://mrale.ph/irhydra/

Depends on D9856

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3333ccf6f6ff
Remove dead constant in JitSpewer.h r=IainIreland
https://hg.mozilla.org/integration/autoland/rev/cde1c74945a2
Remove C1Spewer r=jandem

Comment 4

[Arthur Iakab [arthur_iakab]]

Backed out 2 changesets (bug 1502159)for spidermonkey busteges on CacheIRCompiler.cpp:1624 

Backout revision: https://hg.mozilla.org/integration/autoland/rev/fe1c408db5321673b4dfcc2a7236afadbe2bde15

Failed push: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=cde1c74945a22fc553e7893db1c8845b6263d2c3

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=208022434&repo=autoland

:mgaudet Could you please take a look?

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8647ba30013a
Remove dead constant in JitSpewer.h r=IainIreland
https://hg.mozilla.org/integration/autoland/rev/1c2afde752e7
Remove C1Spewer r=jandem

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/8647ba30013a
https://hg.mozilla.org/mozilla-central/rev/1c2afde752e7