1502165 - Crash in audiounit_get_devices_of_type

Status: RESOLVED FIXED

(Core :: Audio/Video: cubeb, defect, P2)

Description

[Marcia Knous [:marcia]]

This bug was filed from the Socorro interface and is
report bp-d4e665aa-1cd7-4547-95b6-877670181023.
=============================================================

Small volume Mac regression, might be similar to Bug 1500109: https://bit.ly/2PUzdE7. Earliest crashes seem to go back to 20181015100128. Affects both 10.13 and 10.14.

Top 10 frames of crashing thread:

0  @0x7fff4bb3fcc5 
1  @0x7fff4bb64863 
2 XUL audiounit_get_devices_of_type media/libcubeb/src/cubeb_audiounit.cpp:3415
3 XUL ___ZL37audiounit_collection_changed_callbackjjPK26AudioObjectPropertyAddressPv_block_invoke media/libcubeb/src/cubeb_audiounit.cpp:3464
4  @0x7fff78bbad4e 
5  @0x7fff78bbbdca 
6  @0x7fff78bc211f 
7  @0x7fff78bc2bd7 
8  @0x7fff78bcb083 
9  @0x7fff78dfb61b 

=============================================================

Comment 1

[Alex Chronopoulos [:achronop]]

This is a regression from Bug 1498519 (commit 4559815).

Comment 2

[Alex Chronopoulos [:achronop]]

Fix up for review in cubeb repo: https://github.com/kinetiknz/cubeb/pull/471

Comment 3

[Alex Chronopoulos [:achronop]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/028d26d752e31ee91b0cff2e62eacdb628d86c9c
Bug 1502165 - Update cubeb from upstream to 9a7a551. r=kinetik

Comment 4

[Alex Chronopoulos [:achronop]]

Git commit picked:
9a7a551 osx: check null reference before using the string (BMO 1502165).

Comment 5

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/028d26d752e3

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Beta approval when you get a chance.

Comment 7

[Alex Chronopoulos [:achronop]]

Attachment: uplfift-9a7a551-to-beta.patch

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Bug 1498519

User impact if declined: Crash when plug/unplug devices on Mac

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: Yes

Needs manual test from QE?: No

If yes, steps to reproduce: 

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): One line change verified in Nightly

String changes made/needed:

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9021826 [details] [diff] [review]
uplfift-9a7a551-to-beta.patch

[Triage Comment]
Fixes a possible crash when plugging or unplugging devices on Mac. Approved for 64.0b6.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/5ea28701a7cb