1502173 - Nightly 65 increase in creditcard engine sync failures

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Leif Oines [:loines]]

Telemetry indicates that there's been in an increase creditcard engine sync failures, with 4% of users with creditcard sync enabled being affected as of 2018-10-24 and the rate appears to be increasing. 

The specific engine failure reason causing the increase is:

`{name=unexpectederror, value=Error: CreditCards is not initialized. Please restart if you flip the pref manually.}`

According to https://sql.telemetry.mozilla.org/queries/59702/source the problem is specific to nightly 65.

See https://sql.telemetry.mozilla.org/queries/59657/source#154279 to see the counts of errors per failure reason

See https://sql.telemetry.mozilla.org/queries/53869#142622 to see the overall number of users affected by an engine error

See also this potentially relevant discourse thread https://discourse.mozilla.org/t/cant-synchronise/32812/4

Comment 1

[Matthew N. [:MattN]]

I think the issue may be because  checks `isAutofillCreditCardsEnabled` but  checks `isAutofillCreditCardsAvailable` (enabled vs. available).

I think [1] should change to `isAutofillCreditCardsAvailable` as Web Payments (and prefs) will still allow using/editing credit cards even if Form Autofill for them is disabled by the user. i.e. the user should not disable credit card storage once it's available.

[1] https://searchfox.org/mozilla-central/rev/e0c879c86b95bdc752b1dbff6088169735674e4a/browser/extensions/formautofill/FormAutofillStorage.jsm#1930
[2] https://dxr.mozilla.org/mozilla-central/rev/c291143e24019097d087f9307e59b49facaf90cb/browser/extensions/formautofill/api.js#120-121

Comment 2

[Matthew N. [:MattN]]

I think the issue may be because [1] checks `isAutofillCreditCardsEnabled` but [2] checks `isAutofillCreditCardsAvailable` (enabled vs. available).

I think [1] should change to `isAutofillCreditCardsAvailable` as Web Payments (and prefs) will still allow using/editing credit cards even if Form Autofill for them is disabled by the user. i.e. the user should not disable credit card storage once it's available.

[1] https://searchfox.org/mozilla-central/rev/e0c879c86b95bdc752b1dbff6088169735674e4a/browser/extensions/formautofill/FormAutofillStorage.jsm#1930
[2] https://dxr.mozilla.org/mozilla-central/rev/c291143e24019097d087f9307e59b49facaf90cb/browser/extensions/formautofill/api.js#120-121

Comment 3

[kud]

Hello. I confirm, I've got this problem. https://discourse.mozilla.org/t/cant-synchronise/32812/6

Comment 4

[Mark Hammond [:markh] [:mhammond]]

Matt, are you willing to take this on?

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

I can take it.

Comment 6

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Attachment: Bug 1502173 - Initialize the credit card storage when it is available r=MattN

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4e51b3f9e1e3
Initialize the credit card storage when it is available r=MattN

Comment 8

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/4e51b3f9e1e3