Closed
Bug 1502198
Opened 7 years ago
Closed 7 years ago
GitHubAuth cannot be removed from user_info_class in data/params if extension enabled or all logins will no longer work
Categories
(bugzilla.mozilla.org :: Extensions, enhancement)
Tracking
()
RESOLVED
FIXED
People
(Reporter: dkl, Assigned: dkl)
Details
Attachments
(1 file)
The GitHubAuth extension monkey patches Bugzilla::Auth::Login::CGI::can to return undef if method equals 'fail_nodata'. This is fine as long as GitHubAuth is in the user_info_class param. This way the GitHubAuth's fail_nodata is always called first. But if GitHubAuth is not in the user_info_class setting, then the normal CGI::fail_nodata is not called and logins fail to work properly since the login page is not displayed.
We need to update the GitHubAuth extension code to allow the fallbacks to work properly even when GitHubAuth is not being used.
|
Assignee | |
Comment 1•7 years ago
|
||
Assignee: nobody → dkl
Status: NEW → ASSIGNED
|
||
Comment 2•7 years ago
|
||
Merged to master.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Component: Extensions: GitHubAuth → Extensions
You need to log in
before you can comment on or make changes to this bug.
Description
•