GitHubAuth cannot be removed from user_info_class in data/params if extension enabled or all logins will no longer work

RESOLVED FIXED

Status

()

enhancement
RESOLVED FIXED
6 months ago
6 months ago

People

(Reporter: dkl, Assigned: dkl)

Tracking

Staging

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

45 bytes, text/x-github-pull-request
Details | Review
(Assignee)

Description

6 months ago
The GitHubAuth extension monkey patches Bugzilla::Auth::Login::CGI::can to return undef if method equals 'fail_nodata'. This is fine as long as GitHubAuth is in the user_info_class param. This way the GitHubAuth's fail_nodata is always called first. But if GitHubAuth is not in the user_info_class setting, then the normal CGI::fail_nodata is not called and logins fail to work properly since the login page is not displayed.

We need to update the GitHubAuth extension code to allow the fallbacks to work properly even when GitHubAuth is not being used.
(Assignee)

Comment 1

6 months ago
Posted file GitHub Pull Request
Assignee: nobody → dkl
Status: NEW → ASSIGNED
Merged to master.
Status: ASSIGNED → RESOLVED
Last Resolved: 6 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.