1502238 - When clearing site data, clear storage permissions assigned to a tracker

Status: RESOLVED FIXED

(Firefox :: Protections UI, enhancement)

Description

[(no longer active)]

If the user has a "3rdPartyStorage^tracker.example" permission stored in their permission manager database, and clears site data for tracker.example, right now that permission will survive.

It would be nice to clear it.

Andrea, any chance you could take this please?  Thanks!

Comment 1

[Andrea Marchesini [:baku]]

Attachment: cleanup.patch

Comment 2

[(no longer active)]

Comment on attachment 9020319 [details] [diff] [review]
cleanup.patch

Review of attachment 9020319 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks a lot!

::: toolkit/components/cleardata/tests/unit/test_permissions.js
@@ +66,5 @@
> +
> +  const oneMoreUri = Services.io.newURI("https://example.org");
> +  const oneMorePrincipal = Services.scriptSecurityManager.createCodebasePrincipal(oneMoreUri, {});
> +  Services.perms.addFromPrincipal(oneMorePrincipal, "cookie",  Services.perms.ALLOW_ACTION);
> +  Services.perms.addFromPrincipal(oneMorePrincipal, "3rdPartyStorage^https://example.net^https://example.org",  Services.perms.ALLOW_ACTION);

For completeness, maybe add a test for 3rdPartyStorage^https://example.org^https://example.net too?

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e9f2f0ad93b3
When clearing site data, clear storage permissions assigned to a tracker, r=ehsan

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/e9f2f0ad93b3