Closed Bug 1502240 Opened 3 years ago Closed 3 years ago
Ensure that Content Blocking allow list is applied to all cookie policies
47 bytes, text/x-phabricator-request
|Details | Review|
We used to special case some cookie policies to honour Disable Protection UI button for 63, but for 65 we want to make them all honour it.
Unfortunately we can't test BEHAVIOR_REJECT using the AntiTracking framework, because the AntiTracking callbacks are incompatible with it. (The tracking callbacks expect to be able to unblock themselves, but under BEHAVIOR_REJECT, that can't happen.)
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/462c7102e2db Ensure that Content Blocking allow list is applied to all cookie policies r=baku
Backed out changeset 462c7102e2db (bug 1502240) for failures related to nsICookieService push that caused the backout: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&group_state=expanded&revision=462c7102e2dbac877e81c8065e1719aada935dcc failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&fromchange=6cfdf048c0e72a0f04acee4da8de18d6af8f0d17&group_state=expanded&selectedJob=209460935&searchStr=linux%2Cdebug%2Cmochitests%2Ctest-linux32%2Fdebug-mochitest-9%2Cm%289%29 backout: https://hg.mozilla.org/integration/autoland/rev/ae1c0d2ca42868e1a0fa32f4c8e4bea9a7352bda
So we hit this assertion <https://searchfox.org/mozilla-central/rev/39cb1e96cf97713c444c5a0404d4f84627aee85d/netwerk/cookie/nsCookieService.cpp#4312> because now the assertion is meaningless. We can end up here with _any_ behavior code. So I will just remove the assertion now.
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/bec76d967002 Ensure that Content Blocking allow list is applied to all cookie policies r=baku
Ehsan, could we manually verify this issue? If yes, could you please provide some steps?
The patch landed with automated tests, no need for manual verification. Thanks!
You need to log in before you can comment on or make changes to this bug.