Closed Bug 1502240 Opened 3 years ago Closed 3 years ago

Ensure that Content Blocking allow list is applied to all cookie policies

Categories

(Firefox :: Protections UI, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 65
Tracking Status
firefox65 --- fixed

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

We used to special case some cookie policies to honour Disable Protection UI button for 63, but for 65 we want to make them all honour it.
Priority: -- → P2
Unfortunately we can't test BEHAVIOR_REJECT using the AntiTracking framework,
because the AntiTracking callbacks are incompatible with it.  (The tracking
callbacks expect to be able to unblock themselves, but under BEHAVIOR_REJECT,
that can't happen.)
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/462c7102e2db
Ensure that Content Blocking allow list is applied to all cookie policies r=baku
So we hit this assertion <https://searchfox.org/mozilla-central/rev/39cb1e96cf97713c444c5a0404d4f84627aee85d/netwerk/cookie/nsCookieService.cpp#4312> because now the assertion is meaningless.  We can end up here with _any_ behavior code.  So I will just remove the assertion now.
Flags: needinfo?(ehsan)
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bec76d967002
Ensure that Content Blocking allow list is applied to all cookie policies r=baku
https://hg.mozilla.org/mozilla-central/rev/bec76d967002
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
Ehsan, could we manually verify this issue? If yes, could you please provide some steps?
Flags: needinfo?(ehsan)
The patch landed with automated tests, no need for manual verification.  Thanks!
Flags: needinfo?(ehsan)
Depends on: 1510860
Depends on: 1515665
Depends on: 1530132
You need to log in before you can comment on or make changes to this bug.