1502481 - JSScript initialization cleanup

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P2)

Description

[Ted Campbell [:tcampbell]]

The initialization sequence is complex for JSScripts and hard to reason about. This bug aims to clean-up that code.

Comment 1

[Ted Campbell [:tcampbell]]

Attachment: Bug 1502481 - Use sourceStart/sourceEnd name within JSScript

Comment 2

[Ted Campbell [:tcampbell]]

Attachment: Bug 1502481 - Cleanup JSScript nits

Depends on D9944

Comment 3

[Ted Campbell [:tcampbell]]

Attachment: Bug 1502481 - Cleanup JSScript constructor calls

This reorganizes the JSScript constructor sequence into the following
layers and responsibilities:

  JSScript(...)         The actual C++ constructor putting script in
                        GC-safe state.
  JSScript::New(...)    Performs allocation within GC.
  JSScript::Create(...) Common initialization for all script
                        initialization pathways.

This is more in-line with how other GC-things are created. The bitfields
saved from compile options are now done at the JSScript::Create level.

Depends on D9945

Comment 4

[Ted Campbell [:tcampbell]]

Attachment: Bug 1502481 - Rename JSScript partiallyInit and friends

JSScript::partiallyInit -> JSScript::createPrivateScriptData
JSScript::createScriptData -> JSScript::createSharedScriptData

Depends on D9946

Comment 5

[Ted Campbell [:tcampbell]]

Attachment: Bug 1502481 - Cleanup JSScript::initFunctionPrototype

Depends on D9947

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6ae3b85ff64c
Use sourceStart/sourceEnd name within JSScript r=jandem
https://hg.mozilla.org/integration/autoland/rev/8ef875ecc917
Cleanup JSScript nits r=jandem
https://hg.mozilla.org/integration/autoland/rev/170515f4f874
Cleanup JSScript constructor calls r=jandem
https://hg.mozilla.org/integration/autoland/rev/63cb6b558afe
Rename JSScript partiallyInit and friends r=jandem
https://hg.mozilla.org/integration/autoland/rev/c25dd8708e93
Cleanup JSScript::initFunctionPrototype r=jandem

Comment 7

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/6ae3b85ff64c
https://hg.mozilla.org/mozilla-central/rev/8ef875ecc917
https://hg.mozilla.org/mozilla-central/rev/170515f4f874
https://hg.mozilla.org/mozilla-central/rev/63cb6b558afe
https://hg.mozilla.org/mozilla-central/rev/c25dd8708e93