Closed Bug 1502510 Opened 3 years ago Closed 3 years ago

background-image blue-32x32.png not fetched in 4 calc() on background tests

Categories

(Core :: Layout, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: bugzilla, Assigned: dholbert)

References

Details

Attachments

(1 file)

Just focusing on the first test file (I assume this applies to all of them): it originally lived here:
  https://hg.mozilla.org/mozilla-central/annotate/983d21f8af4a/layout/reftests/css-calc/background-position-1.html
...and for that location, the '../backgrounds/blue-32x32.png' path was (and is still) valid -- it refers to this file:

hgweb: https://hg.mozilla.org/mozilla-central/annotate/tip/layout/reftests/backgrounds/blue-32x32.png
raw file: https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/reftests/backgrounds/blue-32x32.png

The test was moved to layout/reftests/w3c-css in bug 826582 (and the version you referenced in wpt is a copy of that version).  But we apparently missed the fact that it was depending on an external resource when we did that file-move.
Depends on: 826582
Priority: -- → P3
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Note: my patch here fixes the "master" copy of this test, in layout/reftests/w3c-css/submitted.  The WPT version should be fixed as well, the next time we synchronize this reftest directory upstream (which I think dbaron does ~weekly or so).

FWIW, I loaded the test files locally and verified that the image shows up now, and that the tests still pass (phew). :)
I landed the patch via Lando this morning:
 https://hg.mozilla.org/integration/autoland/rev/9b13397e4ca5
(Not sure why the bot didn't post the cset on this bug.)
https://hg.mozilla.org/mozilla-central/rev/9b13397e4ca5
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.