Closed Bug 1502531 Opened 2 years ago Closed 2 years ago

Upload localconfig.json from build tasks.

Categories

(Release Engineering :: Applications: MozharnessCore, enhancement)

enhancement
Not set
normal

Tracking

(firefox-esr60 fixed, firefox65 fixed)

RESOLVED FIXED
Tracking Status
firefox-esr60 --- fixed
firefox65 --- fixed

People

(Reporter: tomprince, Assigned: tomprince)

References

Details

Attachments

(5 files, 1 obsolete file)

Bug 1462462 stopped printing out the mozharness config, because that duplicated the localconfig.json artifact. However, non-test jobs were not uploading any of the mozharness logs, so that change was reverted in Bug 1466217.

This updates the mozharness transform to upload the logs, so that we can then stop printing the config again.
Taskcluster knows where mozharness generates the logs, and can upload them from
there. Thus, mozharness no longer needs to copy the logs to a new directory.
That variable, and the function that references it is only used by the openh264
code, so move it there.
This content is already available as a separate artifact, localconfig.json.
Pushed by mozilla@hocat.ca:
https://hg.mozilla.org/integration/autoland/rev/69c95a2e61c2
[mozharness] Upload mozharness builds logs; r=Callek
https://hg.mozilla.org/integration/autoland/rev/1f37fdb0b880
[mozharness] Stop needlessly copying around mozharness logs; r=Callek
https://hg.mozilla.org/integration/autoland/rev/a7332ea46f0f
[mozharness] Move `abs_upload_dir` code to openh264_build script; r=Callek
Depends on: 1503209
Assignee: nobody → mozilla
Attachment #9020475 - Attachment is obsolete: true
Pushed by mozilla@hocat.ca:
https://hg.mozilla.org/integration/autoland/rev/0940c61a4f71
[mozharness] Adjust paths used for logs in tests too; r=Callek
(In reply to Cosmin Sabou [:CosminS] from comment #9)
> Push with failures:
> https://treeherder.mozilla.org/#/
> jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&searchStr=mda
> &fromchange=0940c61a4f71c3dbc61e6d8168e8ff3c7b6f90e8&tochange=ccc0d10876ece15
> 77f5bc95b5d0355bd224e9ca6&selectedJob=208836160
> 
> Failure log:
> https://treeherder.mozilla.org/logviewer.
> html#?job_id=208836160&repo=autoland&lineNumber=4138

Unfortunately, the previous push here regressed the error reporting from tests, which is fixed by this push. So I suspect that if the failure above is a perma-failure, then it landed sometime in between the two pushes, and was just made visible by this one.
Flags: needinfo?(mozilla)
Pushed by mozilla@hocat.ca:
https://hg.mozilla.org/integration/autoland/rev/4610b4c5befa
[mozharness] Adjust paths used for logs in tests too; r=Callek
Backout by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/174c9c666cfe
Backed out changeset 4610b4c5befa for causing mass failures on mochitests. CLOSED TREE
Backed out for causing mass failures on mochitests.

Exemple for one test: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&tochange=4610b4c5befa0f89360ab554efcf0dbd9a1e0a07&fromchange=bfe60bb8afc50931f130115099cbabebf4787e11&searchStr=linux%2Copt%2Cmochitests%2Cwith%2Ce10s%2Ctest-linux32%2Fopt-mochitest-media-e10s-3%2Cm-e10s%28mda3%29&selectedJob=208931466

This was failing on test_fingerprinting_resistance.html after 4610b4c5befa landed. https://treeherder.mozilla.org/logviewer.html#?job_id=208931466&repo=autoland&lineNumber=1416 
The same test on the the push before was green https://treeherder.mozilla.org/logviewer.html#?job_id=208938230&repo=autoland&lineNumber=1433
This behavior can be replicated with more mochitests that started failing after the above revision landed. I don't find that the permafails are there but not shown in Treeherder.
Flags: needinfo?(mozilla)
I think these kind of error are more relevant to why are the tests failing: https://treeherder.mozilla.org/logviewer.html#?job_id=208941981&repo=autoland&lineNumber=8326

[task 2018-10-31T17:28:46.550Z] 17:28:46     INFO - TEST-PASS | toolkit/content/tests/browser/browser_autoplay_policy_user_gestures.js | audio context is still suspended - "suspended" == "suspended" - 
[task 2018-10-31T17:28:46.551Z] 17:28:46     INFO - - calling gum with {"audio":true}
[task 2018-10-31T17:28:46.551Z] 17:28:46     INFO - Buffered messages finished
[task 2018-10-31T17:28:46.552Z] 17:28:46     INFO - TEST-UNEXPECTED-FAIL | toolkit/content/tests/browser/browser_autoplay_policy_user_gestures.js | NotFoundError: The object can not be found here. - 
[task 2018-10-31T17:28:46.553Z] 17:28:46     INFO - Stack trace:
[task 2018-10-31T17:28:46.554Z] 17:28:46     INFO - chrome://mochitests/content/browser/toolkit/content/tests/browser/browser_autoplay_policy_user_gestures.js:test_webaudio_with_gum:239
[task 2018-10-31T17:28:46.554Z] 17:28:46     INFO - chrome://mochitests/content/browser/toolkit/content/tests/browser/browser_autoplay_policy_user_gestures.js:start_test:274
[task 2018-10-31T17:28:46.555Z] 17:28:46     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1097
[task 2018-10-31T17:28:46.556Z] 17:28:46     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1088
[task 2018-10-31T17:28:46.556Z] 17:28:46     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:986
[task 2018-10-31T17:28:46.557Z] 17:28:46     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:795
[task 2018-10-31T17:28:46.557Z] 17:28:46     INFO - - calling resume() again
[task 2018-10-31T17:29:11.826Z] 17:29:11     INFO - Not taking screenshot here: see the one that was previously logged

Looks like the actual test files can no longer be found in that tests path that maybe the modifications here deal with those paths, I just assuming this. https://hg.mozilla.org/integration/autoland/diff/4610b4c5befa/taskcluster/taskgraph/transforms/job/mozharness_test.py
Pushed by mozilla@hocat.ca:
https://hg.mozilla.org/integration/autoland/rev/b5e86f196238
[mozharness] Adjust paths used for logs in tests too; r=Callek
Backout by shindli@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/82226a466085
Backed out changeset b5e86f196238 for mda permafailures
Pushed by mozilla@hocat.ca:
https://hg.mozilla.org/integration/mozilla-inbound/rev/094788ee20a8
[mozharness] Adjust paths used for logs in tests too; r=Callek
Flags: needinfo?(mozilla)
Due to Bug 1503756, this couldn't be landed with the changes to the paths, as
it changed the docker image.
Pushed by mozilla@hocat.ca:
https://hg.mozilla.org/integration/autoland/rev/1e4e26d73786
Adjust test script to create the properly log directories; r=Callek
You need to log in before you can comment on or make changes to this bug.