1502751 - Eliminate duplicate set of longhand properties to ignore when overriding author styles

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P3)

Description

[Sean Voisen (:svoisen)]

We have a duplicate set of longhand properties to ignore when overriding author-specified rules (for instance, due to the user specifying high-contrast colors in preferences). See: https://searchfox.org/mozilla-central/source/servo/components/style/rule_tree/mod.rs#1294

This list of properties is already generated by mako, and should be used instead. See:
https://searchfox.org/mozilla-central/rev/5b3b6b8fd9f90087f618c20382e631451136ed2b/servo/components/style/properties/properties.mako.rs#1160

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Don't keep a separate list of ignored-when-colors-disabled longhands.

Most of the change is moving sets around to be static functions on
LonghandIdSet. I think I like that pattern, but I can also make the new set a
global static and add mako code to be `pub` or something.

Though I think the LonghandIdSet::foo().contains(..) pattern is nice to read :)

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dd629ef17f62
Don't keep a separate list of ignored-when-colors-disabled longhands. r=heycam

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/dd629ef17f62