Add reftests for ImageRendering on video (NativeTexture external images)

RESOLVED FIXED in Firefox 65

Status

()

RESOLVED FIXED
5 months ago
5 months ago

People

(Reporter: h.winnemoeller, Assigned: h.winnemoeller)

Tracking

Trunk
mozilla65
Points:
---

Firefox Tracking Flags

(firefox65 fixed)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

5 months ago
Bug 1488555 added the ability to support ImageRendering on video (NativeTexture external images). While working on this bug, I realised that:

- The ImageRendering property on videos (NativeTexture external image) is not tested.
- JS-based changes to the ImageRendering property of a video (NativeTexture external image) are not tested.
- We do not test if the ImageRendering field actually produces any changes. Therefore, a reftest should check for inequality between different ImageRendering settings.

This bug will introduce additional reftests for these cases.
Comment on attachment 9020660 [details] [diff] [review]
4-Bug_1502761___Add_reftests_for_ImageRendering_on_video__NativeTexture_external_images___r_nical.diff

Review of attachment 9020660 [details] [diff] [review]:
-----------------------------------------------------------------

Apologies for the delay, looks good to me!
Attachment #9020660 - Flags: review?(nical.bugzilla) → review+
(Assignee)

Updated

5 months ago
Attachment #9020660 - Attachment is obsolete: true
(Assignee)

Updated

5 months ago
Keywords: checkin-needed

Comment 4

5 months ago
Pushed by nbeleuzu@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/62d95b920270
Add reftests for ImageRendering on video (NativeTexture external images). r=nical
Keywords: checkin-needed
(Assignee)

Comment 6

5 months ago
(In reply to Narcis Beleuzu [:NarcisB] from comment #5)
> Backed out for reftest failures on image-rendering-css.html
> Log link:
> https://treeherder.mozilla.org/logviewer.html#?job_id=208983362&repo=mozilla-
> inbound&lineNumber=1671

Fennec seems to have an issue where the first video frame is always black, see Bug 1370426. This also blocks Bug 1368902. I have disabled the tests on Fennec/Android and will create a new bug to track this issue.

> There were also tier2 TVg failures ".../mp4-video/reftest.list line 4:
> minimum fuzz must be zero for tests of type != "
> Log link:
> https://treeherder.mozilla.org/logviewer.html#?job_id=208984003&repo=mozilla-
> inbound&lineNumber=940

I have adapted the fuzz minimum values.
Attachment #9021597 - Attachment is obsolete: true
Flags: needinfo?(h.winnemoeller)
(Assignee)

Updated

5 months ago
Keywords: checkin-needed

Comment 7

5 months ago
Pushed by nbeleuzu@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/db853d5005c7
Add reftests for ImageRendering on video (NativeTexture external images). r=nical
Keywords: checkin-needed

Comment 8

5 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/db853d5005c7
Status: ASSIGNED → RESOLVED
Last Resolved: 5 months ago
status-firefox65: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.