1502797 - Reimplement BigInt in terms of JSC/V8 code instead of GMP

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P2)

Description

[Andy Wingo [:wingo]]

Patch forthcoming to reimplement bignums in terms of JSC/V8 code.  Besides absolving us of a dependency, this has a couple more advantages:

 * Better out-of-memory handling; allocations can fail and will be handled by standard JSC mechanisms.
 * Inline digit storage for 64-bit values.

Comment 1

[Andy Wingo [:wingo]]

(See https://bugzilla.mozilla.org/show_bug.cgi?id=1494346 for more discussion.)

Comment 2

[Andy Wingo [:wingo]]

Attachment: Bug 1502797 - Remove redundant forward declarations of BigInt type

Comment 3

[Andy Wingo [:wingo]]

Attachment: Bug 1502797 - Reimplement BigInt using V8/JSC code instead of GMP

Depends on D10045

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/468165ff69b2
Remove redundant forward declarations of BigInt type r=jandem

Comment 5

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/468165ff69b2

Comment 6

[Jeff Walden [:Waldo]]

FWIW I just landed https://hg.mozilla.org/integration/mozilla-inbound/rev/91c06aa99424f98be5d97d288216008d1c5698e9 which changes up the names of some of the FloatingPoint<double>::k* constants.  It is possible some of the constants used in the current patch, are better expressed using different idioms that rev implements.

Comment 7

[Jeff Walden [:Waldo]]

...yeah yeah, I need to get to the request here.  Today, I hope?  Phabricator decided to Phabricate all over this with the initial comments all gone askew from the places that were actually changed accordingly, and when I tried to review this two weeks ago I ran into that roadblock and gave up on trying to do that review on the plane to Orlando.  :-(

Comment 8

[Robin Templeton [:terpri]]

Attachment: arcpatch-D10046-range-diff.txt

git range-diff for the rebase in phabricator diff #12

Comment 9

[Andy Wingo [:wingo]]

Setting checkin-needed based on r+ from jwalden. Subsequent revisions just rebase and fix a couple nits mentioned in the acceptance message. Woo hoo!!

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/375bd8800b2d
Reimplement BigInt using V8/JSC code instead of GMP r=jwalden

Comment 11

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/375bd8800b2d