1502802 - Implement PostMessageOptions for MessagePort

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P2)

Description

[Andrea Marchesini [:baku]]

See https://github.com/whatwg/html/issues/3799

Comment 1

[Andrea Marchesini [:baku]]

Attachment: part 1 - messagePort.postMessage

I add to invert the "optional" in the postMessage parameters because webIDL requires dictionary to be optional. Is this a limitation in our implementation or is it a bug in the spec?

Comment 2

[Andrea Marchesini [:baku]]

I filed a spec issue: https://github.com/whatwg/html/issues/4137

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 9020701 [details] [diff] [review]
part 1 - messagePort.postMessage

this captures only one postMessage. The dictionary was added for example to window.postMessage.

Comment 4

[Andrea Marchesini [:baku]]

you are too fast in the review process! I was going to upload 4 more patches :)

Comment 5

[Andrea Marchesini [:baku]]

Attachment: part 2 - window.postMessage

Comment 6

[Andrea Marchesini [:baku]]

Attachment: part 3 - worker.postMessage

Comment 7

[Andrea Marchesini [:baku]]

Attachment: part 4 - SW/client.postMessage

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 9020714 [details] [diff] [review]
part 2 - window.postMessage

Oh, PostMessageMoz implementation is silly. Requiring transfers as JSValue. Not exactly fast.
But ok, not about this bug.

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/13762 for changes under testing/web-platform/tests

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Can't merge web-platform-tests PR due to failing upstream checks:
Github PR https://github.com/web-platform-tests/wpt/pull/13762
* continuous-integration/appveyor/pr
* Taskcluster (pull_request) (https://tools.taskcluster.net/task-group-inspector/#/FQ4am-crSnuF85_wggYWlQ)

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2b6babc63893
Implement PostMessageOptions for MessagePort, r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/5096ab6d4f2a
Implement PostMessageOptions for Window, r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/815f3200c6ce
Implement PostMessageOptions for Worker, r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/bc4333f4fabb
Implement PostMessageOptions for Client and ServiceWorker, r=smaug

Comment 12

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/2b6babc63893
https://hg.mozilla.org/mozilla-central/rev/5096ab6d4f2a
https://hg.mozilla.org/mozilla-central/rev/815f3200c6ce
https://hg.mozilla.org/mozilla-central/rev/bc4333f4fabb

Comment 13

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged