Closed Bug 1502802 Opened 2 years ago Closed 2 years ago

Implement PostMessageOptions for MessagePort

Categories

(Core :: DOM: Core & HTML, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: baku, Assigned: baku)

Details

Attachments

(4 files)

I add to invert the "optional" in the postMessage parameters because webIDL requires dictionary to be optional. Is this a limitation in our implementation or is it a bug in the spec?
Attachment #9020701 - Flags: review?(bugs)
Comment on attachment 9020701 [details] [diff] [review]
part 1 - messagePort.postMessage

this captures only one postMessage. The dictionary was added for example to window.postMessage.
Attachment #9020701 - Flags: review?(bugs) → review-
you are too fast in the review process! I was going to upload 4 more patches :)
Attachment #9020714 - Flags: review?(bugs)
Attachment #9020715 - Flags: review?(bugs)
Attachment #9020716 - Flags: review?(bugs)
Attachment #9020701 - Attachment description: post_transfer.patch → part 1 - messagePort.postMessage
Attachment #9020701 - Flags: review- → review?(bugs)
Attachment #9020701 - Flags: review?(bugs) → review+
Comment on attachment 9020714 [details] [diff] [review]
part 2 - window.postMessage

Oh, PostMessageMoz implementation is silly. Requiring transfers as JSValue. Not exactly fast.
But ok, not about this bug.
Attachment #9020714 - Flags: review?(bugs) → review+
Attachment #9020715 - Flags: review?(bugs) → review+
Attachment #9020716 - Flags: review?(bugs) → review+
Priority: -- → P2
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/13762 for changes under testing/web-platform/tests
Can't merge web-platform-tests PR due to failing upstream checks:
Github PR https://github.com/web-platform-tests/wpt/pull/13762
* continuous-integration/appveyor/pr
* Taskcluster (pull_request) (https://tools.taskcluster.net/task-group-inspector/#/FQ4am-crSnuF85_wggYWlQ)
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2b6babc63893
Implement PostMessageOptions for MessagePort, r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/5096ab6d4f2a
Implement PostMessageOptions for Window, r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/815f3200c6ce
Implement PostMessageOptions for Worker, r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/bc4333f4fabb
Implement PostMessageOptions for Client and ServiceWorker, r=smaug
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.