Display locked preferences in a different style

RESOLVED FIXED in Firefox 65

Status

()

enhancement
P1
normal
RESOLVED FIXED
9 months ago
8 months ago

People

(Reporter: Paolo, Assigned: lschwalf)

Tracking

(Blocks 1 bug)

Trunk
mozilla65
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox65 fixed)

Details

Attachments

(1 attachment)

In the redesigned "about:config" page, we should display rows for locked preferences in a different style, and with an indication that they are locked.
Assignee: nobody → lschwalfenberg
Before submitting this patch for an initial review I tried a version of it where I disabled the buttons (delete user added pref/reset modified pref) on the DOM, but when I was testing it locally it seemed to be behaving inconsistently in the test.

I also thought about adding a svg lock icon like in Matthias's mockup, but I thought that might make table rows a look unbalanced in the current prototype. As such, I decided to keep the styling minimalist and just change the opacity of each locked row for now. This code also makes sure that for any preference that is locked, that these preferences do not get any kind of button in their "button" column. I also thought about possibility adding a status column, but I wasn't sure if that was something we wanted at this point of the prototype. 

Let me know if you want me to still try one of those other avenues. I think it probably still makes sense to show the buttons and just have them disabled.
(In reply to Luke Schwalfenberg [:lschwalf] from comment #2)
> I also thought about adding a svg lock icon like in Matthias's mockup, but I
> thought that might make table rows a look unbalanced

To solve this, for the moment we could just display the locks before the value column instead or the name column. For most preferences, the space reserved for it would look like a margin between the name and the value.

> Let me know if you want me to still try one of those other avenues. I think
> it probably still makes sense to show the buttons and just have them
> disabled.

Yes, it makes sense, let me or another mentor know if you had a specific problem with the test and we may be able to help.
You will probably need to edit the lines where we select the pref to test such that we do not try to hit "edit" etc on a locked pref.
Pushed by paolo.mozmail@amadzone.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/871b06663b0d
Display locked preferences in a different style. r=paolo
Pushed by paolo.mozmail@amadzone.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0177a4902e5e
Fix intermittent failure surfaced by test-verify. r=me
Status: NEW → ASSIGNED
Priority: P2 → P1
https://hg.mozilla.org/mozilla-central/rev/871b06663b0d
https://hg.mozilla.org/mozilla-central/rev/0177a4902e5e
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.