Open Bug 1502932 Opened 7 years ago Updated 1 year ago

Audit JS::ExposeObjectToActiveJS uses

Categories

(Core :: JavaScript Engine, enhancement, P3)

Product:
Core
Component:
JavaScript Engine
Type:
enhancement

Tracking

()

People

(Reporter: jorendorff, Unassigned)

References

(Blocks 1 open bug)

Details

- The comment on this function should emphasize that you probably do not need to call it, because you're using `Heap<>`, right? Reading from a `Heap<>` automatically exposes the object (i.e. marks it black) for you. - But also, the comment should say clearly when it is neccessary to call the function. It's a critical correctness rule for embeddings like Gecko. Describing the rules in terms of GC internals is bad. - The DOM bindings currently call this function on JS::RootedObjects. This is always redundant, modulo bugs; we should change it to an assertion.
Depends on: 1568539
Severity: normal → S3
Blocks: sm-api
Severity: S3 → N/A
You need to log in before you can comment on or make changes to this bug.