1502977 - Startup crashes with fbplugin on macos

Status: RESOLVED FIXED

(External Software Affecting Firefox :: Other, defect)

Description

[[:philipp]]

This bug was filed from the Socorro interface and is
report bp-2ecb6ae5-30bb-4bff-b0b3-5118f0181028.
=============================================================

Top 10 frames of crashing thread:

0 CoreFoundation CFBasicHashFindBucket 
1 fbplugin fbplugin@0xeb8 
2 fbplugin fbplugin@0x22e9 
3  @0x118f9fa09 
4  @0x118f9fc39 
5  @0x118f9b16f 
6  @0x118f9a2a5 
7  @0x118f9a339 
8  @0x118f8e3e4 
9  @0x118f97001 

=============================================================

after the update to firefox 63, there's an uptick in startup crashes on various versions of macos with the involvement of "fbplugin", that was already causing problems on other occasions (bug 1086977).

this is currently accounting for close to 10% of browser crashes from macos, though it's hitting individual installations repeatedly.

Comment 1

[[:philipp]]

the issue is also coming up on sumo a couple of times:
https://support.mozilla.org/questions/firefox?owner=all&tagged=bug1502977&show=all

Comment 2

[Marcia Knous [:marcia]]

Added a few more signature. I counted a total of about 350 crashes so far, but as philipp notes in Comment 0 some individuals are crashing more than once.

Comment 4

[Marcia Knous [:marcia]]

Adding a 10.14 specific signature.

Comment 5

[Marco Castelluccio [:marco]]

It looks like the plugin block that was introduced in bug 1086977 has been removed (inadvertently?) by bug 1348273.

Comment 6

[Gabriele Svelto [:gsvelto]]

Oh gosh, I wanted to update that annotation and change the second part in a proper removal but I must have forgotten about it. Patch coming to put it back.

Comment 7

[Gabriele Svelto [:gsvelto]]

Attachment: Bug 1502977 - Reinstate the code blocking the "Facebook Photo Uploader" plugin on Mac and update the associated annotation

Comment 8

[[:philipp]]

hi jim, is it possible to review this patch soon? it would be very nice to see this uplifted to 64 still (because for a mac issue, it's getting mentioned fairly frequently on SUMO) - but the window where that's possible is closing soon.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/646caf2d4577
Reinstate the code blocking the "Facebook Photo Uploader" plugin on Mac and update the associated annotation r=jmathies

Comment 10

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/646caf2d4577

Comment 11

[Marco Castelluccio [:marco]]

Want to request uplift?

Comment 12

[Gabriele Svelto [:gsvelto]]

Yes, right away

Comment 13

[Gabriele Svelto [:gsvelto]]

Comment on attachment 9026230 [details]
Bug 1502977 - Reinstate the code blocking the "Facebook Photo Uploader" plugin on Mac and update the associated annotation

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Bug 1348273

User impact if declined: Firefox crashes on startup

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: Yes

Needs manual test from QE?: No

If yes, steps to reproduce: 

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): The patch only adds back code that was already preventing this problem from happening

String changes made/needed: None

Comment 14

[Julien Cristau [:jcristau]]

Comment on attachment 9026230 [details]
Bug 1502977 - Reinstate the code blocking the "Facebook Photo Uploader" plugin on Mac and update the associated annotation

block crashing plugin, approved for 64.0rc1

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/028d808491d7