Closed Bug 1503207 Opened 2 years ago Closed 2 years ago
Weak Ptr .h
47 bytes, text/x-phabricator-request
|Details | Review|
The nsWeakPtr.h header is essentially empty and has always been like that since the CVS-to-Mercurial migration. It doesn't serve any visible purpose so we might as well remove it. Additionally nsIWeakReference.idl includes nsWeakReferenceUtils.h and vice-versa which is not very useful either. Most classes using weak references use nsWeakPtr but we've got a handful of classes using nsCOMPtr<nsIWeakReference> instead. We might switch those to nsWeakPtr for consistency. Last but not least there's quite a few sources that still include weak reference-related includes but don't use them anymore (mostly because they've been switched to WeakPtr) so we should clean those up.
Assignee: nobody → gsvelto
Status: NEW → ASSIGNED
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/c4633ad9220f Remove nsWeakPtr.h and cleanup all files including weak reference-related headers r=froydnj
It is still kinda strange, nsWeakReference.h includes nsIWeakReferenceUtils.h, why not just nsIWeakReference.h ?
You need to log in before you can comment on or make changes to this bug.