Status

()

enhancement
RESOLVED FIXED
8 months ago
8 months ago

People

(Reporter: gsvelto, Assigned: gsvelto)

Tracking

(Blocks 1 bug)

unspecified
mozilla65
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox65 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

8 months ago
The nsWeakPtr.h header is essentially empty and has always been like that since the CVS-to-Mercurial migration. It doesn't serve any visible purpose so we might as well remove it. Additionally nsIWeakReference.idl includes nsWeakReferenceUtils.h and vice-versa which is not very useful either.

Most classes using weak references use nsWeakPtr but we've got a handful of classes using nsCOMPtr<nsIWeakReference> instead. We might switch those to nsWeakPtr for consistency.

Last but not least there's quite a few sources that still include weak reference-related includes but don't use them anymore (mostly because they've been switched to WeakPtr) so we should clean those up.
Assignee

Updated

8 months ago
Assignee: nobody → gsvelto
Status: NEW → ASSIGNED

Comment 2

8 months ago
Pushed by gsvelto@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c4633ad9220f
Remove nsWeakPtr.h and cleanup all files including weak reference-related headers r=froydnj

Comment 3

8 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/c4633ad9220f
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65

Comment 4

8 months ago
It is still kinda strange, nsWeakReference.h includes nsIWeakReferenceUtils.h, why not just nsIWeakReference.h ?
You need to log in before you can comment on or make changes to this bug.