1503228 - Move PaintWorkletGlobalScope from dom/worklet to layout/style

Status: RESOLVED FIXED

(Core :: Layout, enhancement, P2)

Description

[Arnaud Bienner]

Similar to what was done for AudioWorkletGlobalScope in bug 1502004.

Comment 1

[Arnaud Bienner]

Attachment: Bug 1503228 - Move PaintWorkletGlobalScope from dom/worklet to layout/style. r=karlt

Comment 2

[Arnaud Bienner]

Push to try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=87f1873e3e9aa5c7a1ff5872dd126ef4893f7307

Comment 3

[Arnaud Bienner]

Try is green.

Comment 4

[Daniel Holbert [:dholbert]]

Just noting because it wasn't initially clear to me: the reason (or "one reason") layout/style is a reasonable home for these files is that PaintWorkletImpl.cpp happens to already live there:
https://searchfox.org/mozilla-central/source/layout/style/PaintWorkletImpl.cpp

Comment 5

[Arnaud Bienner]

Yes :)

And the reason to move things away from dom/worklet is that we want to keep only worklet generic stuff here.
As we are moving forward with AudioWorklet, this seems sensible to move Worklet implementation in the same place where the logic is.
This would also allow to access classes that are not exported, including PaintWorkletImpl.

And that's why that bug is blocking bug 1503236: enforcing PaintWorkletGlobalScope to take a worklet impl of the correct type requires to know about PaintWorkletImpl.

PaintWorkletImpl was introduced recently, as part of bug 1492014. See comment 12 for the reason why layout/style was choosen.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a06d9567c399
Move PaintWorkletGlobalScope from dom/worklet to layout/style. r=karlt

Comment 7

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/a06d9567c399