1503251 - Tracelogger: do not clear all dictionary data when calling js::ResetTraceLogger()

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P2)

Description

[Denis Palmeiro [:denispal]]

Some events persist even when the profiler is stopped, and they may continue to be referenced in the next profiling session.  They are kept track of using a pointer counter for the TraceLoggerEventPayload pointers, but the actual string data that carries the payload gets cleared on reset.  Instead of clearing, append the data we need into a new DictionaryVector and replace the old one with the new dictionary.

Comment 1

[Denis Palmeiro [:denispal]]

Attachment: Keep payload values in the dictionary if they are still alive.

If the JS::ResetTraceLogger() routine is called, then keep track of existing event payloads and keep their existence alive instead of clearing them.  This data can still be referred to in another profiler session and can therefore cause to dangling pointers if we free them.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ec925f7dac88
Keep payload values in the dictionary if they are still alive. r=djvj

Comment 3

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/ec925f7dac88