1503401 - Update cbindgen again.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Emilio Cobos Álvarez (:emilio)]

https://github.com/eqrion/cbindgen/pull/233 changed the way one of the options we use work.

I think the new behavior is better, but we should do this sooner rather than later, and fix broken builds.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Update cbindgen due to breaking change.

https://github.com/eqrion/cbindgen/pull/233 changed the way one of the options
we use work.

I think the new behavior is better, but we should do this sooner rather than
later, and fix broken builds.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Keep mozilla-release building with newer cbindgen versions.

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: N/A

User impact if declined: None

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: No

Needs manual test from QE?: No

If yes, steps to reproduce: 

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): Only keeps the build working with newer versions of a build dependency. It should be a no-op in our automation, which uses a fixed older version.

String changes made/needed:

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Keep mozilla-beta building with newer cbindgen versions.

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: N/a

User impact if declined: None

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: No

Needs manual test from QE?: No

If yes, steps to reproduce: 

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): See justification in the previous comment.

String changes made/needed: none

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Tests so this doesn't happen again in https://github.com/eqrion/cbindgen/pull/236.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5b0e4820c7fb
Update cbindgen due to breaking change. r=boris

Comment 6

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/5b0e4820c7fb

Comment 7

[Jan Beich]

Comment on attachment 9021333 [details] [diff] [review]
Keep mozilla-release building with newer cbindgen versions.

Doesn't appear to help on top of 63.0.1, see https://ptpb.pw/Gm7b (build log). Am I missing more patches?

Comment 8

[Emilio Cobos Álvarez (:emilio)]

(In reply to Jan Beich from comment #7)
> Comment on attachment 9021333 [details] [diff] [review]
> Keep mozilla-release building with newer cbindgen versions.
> 
> Doesn't appear to help on top of 63.0.1, see https://ptpb.pw/Gm7b (build
> log). Am I missing more patches?

Hmm, let me double-check.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9021334 [details] [diff] [review]
Keep mozilla-beta building with newer cbindgen versions.

[Triage Comment]
Updates mozilla-beta to work with newer cbindgen versions. Approved for 64.0b6.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/6e4f5a616fe2

Comment 11

[Emilio Cobos Álvarez (:emilio)]

Attachment: Keep mozilla-release building with newer cbindgen versions.

See comment 2.

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: None

User impact if declined: 

Is this code covered by automated tests?: Yes

Has the fix been verified in Nightly?: Yes

Needs manual test from QE?: Yes

If yes, steps to reproduce: 

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): 

String changes made/needed:

Comment 12

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9021333 [details] [diff] [review]
Keep mozilla-release building with newer cbindgen versions.

This was missing a comma, d'oh.

Comment 13

[Pascal Chevrel:pascalc]

Comment on attachment 9021658 [details] [diff] [review]
Keep mozilla-release building with newer cbindgen versions.

Updates mozilla-release to work with newer cbindgen versions. Approved for 63.0.3.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/22273af49058