1503424 - [10.10] Crash in -[ChildView initWithFrame:geckoChild:]

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Marcia Knous [:marcia]]

As noted in Bug 1491580, there are still users crashing in this stack running 10.10 - see https://bit.ly/2ETsrgW. Currently in 63 there are 200 crashes/90 installations. So far only 63 is shown as affected.

Comment 1

[Pascal Chevrel:pascalc]

Markus, all the crashes are startup crashes which is concerning, could this bug be prioritized and investigated? Thanks

Comment 2

[Markus Stange [:mstange]]

That is concerning, yes. The crashes happen in this instruction:

> 0000000002334675         movq       _NSWorkspaceAccessibilityDisplayOptionsDidChangeNotification_506d5d8, %rcx
> 000000000233467c         movq       (%rcx), %r8 ; <---- this dereference crashes

So that must mean that NSWorkspaceAccessibilityDisplayOptionsDidChangeNotification just contains a null string. That's surprising to me because the Apple docs say that this constant is available on 10.10+.

We could just add a null check and it should fix the crash.

Comment 3

[Markus Stange [:mstange]]

Attachment: Bug 1503424 - Null-check NSWorkspaceAccessibilityDisplayOptionsDidChangeNotification before using it in order to fix a startup crash on 10.10. r?hiro

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8104ed059167
Null-check NSWorkspaceAccessibilityDisplayOptionsDidChangeNotification before using it in order to fix a startup crash on 10.10. r=hiro

Comment 5

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/8104ed059167

Comment 6

[Markus Stange [:mstange]]

Here's the list of affected macOS versions:

10.10.0 14A238x
10.10.0 14A329r
10.10.0 14A299l
10.10.0 14A261i
10.10.0 14A329f
10.10.0 14A314h
10.10.0 14A283o
10.10.0 14A298i

All of these have a letter at the end, I think this mean that all of them are preview releases.

Comment 7

[Markus Stange [:mstange]]

Comment on attachment 9023437 [details]
Bug 1503424 - Null-check NSWorkspaceAccessibilityDisplayOptionsDidChangeNotification before using it in order to fix a startup crash on 10.10. r?hiro

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Bug 1486971

User impact if declined: Startup crash on 10.10 preview releases

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: No

Needs manual test from QE?: No

If yes, steps to reproduce: 

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): just a null-check, should be zero risk

String changes made/needed:

Comment 8

[Hiroyuki Ikezoe (:hiro)]

(In reply to Markus Stange [:mstange] from comment #6)
> Here's the list of affected macOS versions:
> 
> 10.10.0 14A238x
> 10.10.0 14A329r
> 10.10.0 14A299l
> 10.10.0 14A261i
> 10.10.0 14A329f
> 10.10.0 14A314h
> 10.10.0 14A283o
> 10.10.0 14A298i
> 
> All of these have a letter at the end, I think this mean that all of them
> are preview releases.

That makes perfect sense! Thank you!

Comment 9

[Julien Cristau [:jcristau]]

Comment on attachment 9023437 [details]
Bug 1503424 - Null-check NSWorkspaceAccessibilityDisplayOptionsDidChangeNotification before using it in order to fix a startup crash on 10.10. r?hiro

fix for startup crash on macos 10.10 preview releases, approved for 64.0b9

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/dc2f3f105676

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Decently-high volume startup crash on release, probably worth tracking.

Comment 12

[Pascal Chevrel:pascalc]

Comment on attachment 9023437 [details]
Bug 1503424 - Null-check NSWorkspaceAccessibilityDisplayOptionsDidChangeNotification before using it in order to fix a startup crash on 10.10. r?hiro

Crash fix for a startup crash on MacOS 10.10, approved for 63.0.3, thanks.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/5783aac8a1de