1503577 - Remove more nsPrimitiveHelpers::CreateDataFromPrimitive usage

Status: RESOLVED FIXED

(Core :: Widget, enhancement)

Description

[Tom S [:evilpie]]

CreateDataFromPrimitive is a bad abstraction. It gives you back raw bytes, that are either 8-bit chars or 16-bit chars. Some callers even rely on the function returning char16_t, because they know that CreateDataFromPrimitive only returns 8bit chars for kTextMime or kCustomTypesMime flavors.

Comment 1

[Tom S [:evilpie]]

Attachment: Bug 1503577 - Remove CreateDataFromPrimitive from macOS clipboard code. r?spohl

The previous |if (data)| check is not quite the same as !data.IsEmpty(), because
the previous code just checked if the do_QueryInterface failed, but not if the resulting
string is empty.

Comment 2

[Tom S [:evilpie]]

Attachment: Bug 1503577 - Change CreateDataFromPrimitive aDataLen to out parameter with size of string in bytes. r?mstange

Right now CreateDataFromPrimitive doesn't use the aDataLen parameter, and after this change the out
value should be the same as the value passed in, as long as we are dealing with strings.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2df61d7610d6
Remove CreateDataFromPrimitive from macOS clipboard code. r=spohl
https://hg.mozilla.org/integration/autoland/rev/8b1dc4b08aab
Change CreateDataFromPrimitive aDataLen to out parameter with size of string in bytes. r=mstange

Comment 4

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/2df61d7610d6
https://hg.mozilla.org/mozilla-central/rev/8b1dc4b08aab