1503600 - Reorder "Manage Extension" and "Remove Extension" in browserAction context menu

Status: VERIFIED FIXED

(WebExtensions :: Frontend, defect)

Description

[Oriol Brufau [:Oriol]]

Attachment: screenshot.png

Bug 1401610 added a "Remove Extension" item in the toolbar icon context menu.

This was according to https://mozilla.invisionapp.com/share/T7DZLW5CR, where it looks good because there extra items provided by the add-on at the top of the context menu.

But if the add-on doesn't add any custom items there, then the first one is "Remove Extension". I don't think such a predominant position is appropriate for an option that most probably won't be used regularly.

And I think it's easier to click the first item accidentally. Some people don't read confirmation dialogs, so this may end up causing data loss for them. It will be their fault, but moving the item so that it's not that easy to click by mistake would be beneficial.

So I think it would be better to have "Manage Extension" first and "Remove Extension" second.

Emanuela (UX) approved the change in bug 1401610 comment 30.

Comment 1

[Oriol Brufau [:Oriol]]

Attachment: Bug 1503600 - Reorder "Manage Extension" and "Remove Extension" in browserAction context menu. r=Gijs

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/777c4f39c2b8
Reorder "Manage Extension" and "Remove Extension" in browserAction context menu. r=Gijs

Comment 3

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/777c4f39c2b8

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Please request Beta approval on this when you get a chance.

Comment 5

[Oriol Brufau [:Oriol]]

Verified as fixed on Firefox 65.0a1(3cff4bff1c9d) under Win 10 64-bit, Win 10 32-bit and Lubuntu 18.04.1 LTS 64-bit.

Comment 6

[Oriol Brufau [:Oriol]]

Comment on attachment 9021549 [details]
Bug 1503600 - Reorder "Manage Extension" and "Remove Extension" in browserAction context menu. r=Gijs

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Bug 1401610

User impact if declined: Worse UX, see comment 0.

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: Yes

Needs manual test from QE?: No

If yes, steps to reproduce: 

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): Just reorders two context menu items

String changes made/needed:

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9021549 [details]
Bug 1503600 - Reorder "Manage Extension" and "Remove Extension" in browserAction context menu. r=Gijs

[Triage Comment]
Improved UX for the browserAction context menu. Approved for 64.0b6.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/2059d2a6dc80