1503611 - Preview of theme is stretched

Status: RESOLVED WORKSFORME

(Toolkit :: Add-ons Manager, defect, P3)

Description

[Andreas Wagner [:TheOne] [use NI]]

Attachment: screenshot.png

I am running 64b5, my add-ons manager shows some theme previews stretched. See "Litefox" and "Dark Fox" in the attached screenshot. Interestingly, "Fiery Lion" looks ok.

Comment 2

[[:philipp]]

regressed by bug 1495713

Comment 3

[Amy Tsay [:amyt]]

I don't see this happening on Nightly. Andreas, will you check again?

Comment 4

[Mark Striemer [:mstriemer]]

I've reproduced this. I think I did it by installing a theme with about:addons open, but not sure if that's required. It looks like one screenshot is cached and it isn't always the largest one (but often is).

Comment 5

[Mark Striemer [:mstriemer]]

It looks like updates are the culprit here.

STR

1. Install a theme
2. Go to about:addons#themes
3. Check for updates
4. Refresh the page

Expected: No changes.
Actual: Sometimes the preview image will change to the smaller one.

This appears to be due to the update API returning preview.jpg [1] instead of preview_large.jpg which is used when installing.

I filed https://github.com/mozilla/addons-server/issues/10009 against addons-server to fix the issue. I'm guessing updating to static themes will also fix this since it will be using a different code path.

There is also the issue of the built-in themes (from Customize) which ship with the small preview and don't include an updateURL (which also causes an error when updating since it doesn't check if there is an update URL or not).

[1] https://github.com/mozilla/addons-server/blob/8daf0e5383158037253f78e2f5cee9a69df472c8/services/theme_update.py#L184

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

Marking fix-optional for 65 and 66 so that these already triaged issues don't show up repeatedly in weekly regression triage. Happy to take a patch in nightly.

Comment 7

[leifeld]

Removing and installing the addon fixed the bug.
But the installed theme is now apparently a static one, after the big theme conversation.
When /if all installed themes are updated to the converted ones, the bug would be fixed.

Comment 8

[Mark Striemer [:mstriemer]]

Based on comments 5 and 7 it looks like this should be fixed now.