1503659 - Remove the instrumentation bug 1493849 and bug 1496805 and bug 1499150 added from Firefox 64

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P1)

Description

[Boris Zbarsky [:bzbarsky]]

Breaking off from bug 1491925 so we can land this directly on beta.  Note that bug 1501479 never landed on 64.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Back out some debugging instrumentation from Firefox 64, now that it's in beta

Comment 2

[Boris Zbarsky [:bzbarsky]]

I produced that patch by doing:

  hg backout 6b57b7631a5d
  hg backout a994947dd760
  hg backout eddaf25ccc76

and then folding the three changesets together.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 9021611 [details] [diff] [review]
Back out some debugging instrumentation from Firefox 64, now that it's in beta

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Debugging  instrumentation

User impact if declined: Worse performance and possible extra crashes

Is this code covered by automated tests?: Yes

Has the fix been verified in Nightly?: No

Needs manual test from QE?: No

If yes, steps to reproduce: 

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): Backs out a bunch of MOZ_CRASH bits and some of their supporting infrastructure, which is where nightly was a few weeks ago.

Note that I am not backing these out on nightly, where I am still gathering data, hence this fix not being "verified in Nightly".

String changes made/needed: None.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9021611 [details] [diff] [review]
Back out some debugging instrumentation from Firefox 64, now that it's in beta

[Triage Comment]
Removes some debugging instrumentation to avoid perf and stability issues. Approved for 64.0b6.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/0a7792cc133f