Closed
Bug 1503747
Opened 6 years ago
Closed 6 years ago
Skia m71 (Firefox 65 branch) fails to build on big endian systems
Categories
(Core :: Graphics, defect, P3)
Tracking
()
RESOLVED
FIXED
mozilla65
| Tracking | Status | |
|---|---|---|
| firefox65 | --- | fixed |
People
(Reporter: awilfox, Assigned: lsalzman)
References
Details
Attachments
(1 file, 1 obsolete file)
|
690 bytes,
patch
|
lsalzman
:
review+
|
Details | Diff | Splinter Review |
The new Skia code that landed in bug 1502152 breaks building on big-endian again (somewhat a regression of 849253 or 1144632 if you want to go so far). Patches from Marcus Comstedt that are being upstreamed to Chromium (see https://wiki.raptorcs.com/wiki/Porting/Chromium/BE etc) fix the build on BE targets.
|
Reporter | |
Comment 1•6 years ago
|
||
Squashed HG commit of the two Chromium git patches.
Attachment #9021712 -
Flags: review?(lsalzman)
Pushed by lsalzman@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/20ae9023dd79 don't build unused SkJSON. r=me
|
Assignee | |
Comment 3•6 years ago
|
||
Comment on attachment 9021712 [details] [diff] [review] Fix Skia build on big-endian targets These patches are unnecessary as we can just disable building of SkJSON entirely, it turns out.
Attachment #9021712 -
Flags: review?(lsalzman)
|
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → lsalzman
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
|
|
Reporter | |
Comment 4•6 years ago
|
||
That fixes the SkJSON issue, but not the SkCodecPriv.h file missing the SkEndian.h inclusion. I'll make a new patch that contains just that fix.
|
||
Comment 5•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/20ae9023dd79
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
|
|
Reporter | |
Comment 6•6 years ago
|
||
This is not resolved. I specifically mentioned that the SkCodecPriv.h file still needs to be fixed.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
Reporter | |
Comment 7•6 years ago
|
||
This drops the SkJSON patches that are unnecessary since SkJSON is NPOTB now.
Attachment #9021712 -
Attachment is obsolete: true
Attachment #9022015 -
Flags: review?(lsalzman)
|
|
Assignee | |
Comment 8•6 years ago
|
||
(In reply to A. Wilcox [:awilfox] from comment #7) > Created attachment 9022015 [details] [diff] [review] > Fix Skia build on big-endian targets > > This drops the SkJSON patches that are unnecessary since SkJSON is NPOTB now. Why is the SkEndian.h header necessary to include there? We don't build any of the actual codecs, so I am not sure how this would affect anything.
Flags: needinfo?(AWilcox)
|
|
Assignee | |
Comment 9•6 years ago
|
||
Comment on attachment 9022015 [details] [diff] [review] Fix Skia build on big-endian targets Oh, I see. SkCodecPriv.h uses some EndianSwaps conditionally on big-endian.
Flags: needinfo?(AWilcox)
Attachment #9022015 -
Flags: review?(lsalzman) → review+
|
||
Comment 10•6 years ago
|
||
Pushed by lsalzman@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/61f04931011f Fix Skia build on big-endian targets. r=lsalzman
|
||
Comment 11•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/61f04931011f
Status: REOPENED → RESOLVED
Closed: 6 years ago → 6 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•