[socket-proc] Create PBackground between the socket process socket thread and content process

RESOLVED FIXED

Status

()

enhancement
P1
normal
RESOLVED FIXED
6 months ago
3 months ago

People

(Reporter: mayhemer, Assigned: kershaw)

Tracking

(Blocks 2 bugs)

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox65 affected)

Details

(Whiteboard: [necko-triaged], URL)

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

6 months ago
This is one thing we need to deliver to let the WebRTC team use the socket process.

Please any bugs this one is blocking.
(Reporter)

Comment 1

6 months ago
This is only a backup and example, not an actual base patch to fix this bug!  It's half done, currently uncompilable (details follow)

What needs to be added:
- We must call BackgroundChild::Startup() from SocketProcessImpl::Init (after we init XPCOM)
- Add InitBackground message on PSocketProcess parent, see [1][2] as examples
- Implement it on SocketProcessParent as [3]

[1] https://searchfox.org/mozilla-central/rev/eac6295c397133b7346822ad31867197e30d7e94/dom/ipc/PContent.ipdl#731
[2] https://searchfox.org/mozilla-central/search?q=InitBackground&redirect=false
[3] https://searchfox.org/mozilla-central/rev/eac6295c397133b7346822ad31867197e30d7e94/dom/ipc/ContentParent.cpp#3344-3352
Assignee: nobody → honzab.moz
(Reporter)

Updated

6 months ago
Depends on: 1494585
(Reporter)

Comment 3

6 months ago
Reassigning to Kershaw, thanks!
Assignee: honzab.moz → kershaw
(Reporter)

Updated

6 months ago
QA Whiteboard: [necko-triaged]
Priority: -- → P2
(Assignee)

Updated

6 months ago
QA Whiteboard: [necko-triaged]
Whiteboard: [necko-triaged]
(Assignee)

Comment 4

6 months ago
1. Call a new method ChildImpl::GetOrCreateForSocketProcess to get endpoints.
2. Call SocketProcessBridgeChild::SendInitBackground to send endpoint to SocketProcessBridgeparent.
3. In SocketProcessBridgeParent::RecvInitBackground, alloc the background parent with the endpoint.
I need a bit of time to review this patch. It's big and complex. I'll be able to give something in the next 2 days.
Sorry for the delay.
(Reporter)

Updated

5 months ago
Attachment #9021798 - Attachment is obsolete: true
(Reporter)

Updated

5 months ago
Blocks: socket-proc-webrtc
No longer blocks: socket-proc
(Reporter)

Updated

5 months ago
Priority: P2 → P1
(Reporter)

Updated

5 months ago
Blocks: 1484751
(Reporter)

Updated

5 months ago
No longer blocks: socket-proc-webrtc
(Reporter)

Updated

5 months ago
(Assignee)

Comment 6

5 months ago
https://hg.mozilla.org/projects/larch/rev/ee2e6d59c88519ed1b9ae702fdc2f1409ebed2c5
Status: NEW → RESOLVED
Last Resolved: 5 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.