1503834 - [socket-proc] Create PBackground between the socket process socket thread and content process

Status: RESOLVED FIXED

(Core :: Networking, enhancement, P1)

Description

[Honza Bambas (:mayhemer)]

This is one thing we need to deliver to let the WebRTC team use the socket process.

Please any bugs this one is blocking.

Comment 1

[Honza Bambas (:mayhemer)]

Attachment: Example WIP patch for parent process <--> socket process PBackground creation

This is only a backup and example, not an actual base patch to fix this bug!  It's half done, currently uncompilable (details follow)

What needs to be added:
- We must call BackgroundChild::Startup() from SocketProcessImpl::Init (after we init XPCOM)
- Add InitBackground message on PSocketProcess parent, see [1][2] as examples
- Implement it on SocketProcessParent as [3]

[1] https://searchfox.org/mozilla-central/rev/eac6295c397133b7346822ad31867197e30d7e94/dom/ipc/PContent.ipdl#731
[2] https://searchfox.org/mozilla-central/search?q=InitBackground&redirect=false
[3] https://searchfox.org/mozilla-central/rev/eac6295c397133b7346822ad31867197e30d7e94/dom/ipc/ContentParent.cpp#3344-3352

Comment 2

[Honza Bambas (:mayhemer)]

A summary doc for how to implement this:
https://docs.google.com/document/d/1DPTR46RDXzDn5502Al9cMSkQxDCD6R8z1100khM2Jo0/edit

Comment 3

[Honza Bambas (:mayhemer)]

Reassigning to Kershaw, thanks!

Comment 4

[Kershaw Chang [:kershaw]]

Attachment: Bug 1503834 - Create Background between content process and socket process

1. Call a new method ChildImpl::GetOrCreateForSocketProcess to get endpoints.
2. Call SocketProcessBridgeChild::SendInitBackground to send endpoint to SocketProcessBridgeparent.
3. In SocketProcessBridgeParent::RecvInitBackground, alloc the background parent with the endpoint.

Comment 5

[Andrea Marchesini [:baku]]

I need a bit of time to review this patch. It's big and complex. I'll be able to give something in the next 2 days.
Sorry for the delay.

Comment 6

[Kershaw Chang [:kershaw]]

https://hg.mozilla.org/projects/larch/rev/ee2e6d59c88519ed1b9ae702fdc2f1409ebed2c5