1503886 - Two Sponsored cards are wrongly displayed after dismissing all other cards

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P2)

Description

[Ciprian Muresan [:cmuresan], Formerly of Ecosystem QA - please needinfo @mcoman for things regarding the team]

Attachment: two sponsored cards displayed at the same time.gif

[Affected versions]:
- Nightly v65.0a1, Build ID 20181030224027
- Beta 64
- Release 63

[Affected Platforms]:
- All Windows
- All Mac
- All Linux

[Prerequisites]:
- The "browser.search.region" is set to "US" on a clean new profile.

[Steps to reproduce]:
1. Open the browser with the profile from prerequisites and open a new tab.
2. Dismiss all the Recommended by Pocket cards.
3. Open two new tabs or refresh the current one.
4. Observe the behavior.

[Expected results]:
- A single Sponsored card is displayed in the 3rd position.
OR
- No Sponsored card is displayed until the first two positions are occupied.

[Actual results]:
- Two Sponsored cards appear in the first two positions.

[Notes]:
- Attached a screen recording of the issue.

Comment 1

[Ciprian Muresan [:cmuresan], Formerly of Ecosystem QA - please needinfo @mcoman for things regarding the team]

@scott could you please take a look at this?

Comment 2

[Scott [:thecount] Downe]

I think this bug https://bugzilla.mozilla.org/show_bug.cgi?id=1504165 fixes the two spocs issue in this bug, making this only a positioning bug, and there is an ongoing discussion if dismissing a non spoc should move the spoc or not.

Comment 3

[Ciprian Muresan [:cmuresan], Formerly of Ecosystem QA - please needinfo @mcoman for things regarding the team]

Marking this as Resolved Fixed by bug 1504165.

Comment 4

[Ciprian Muresan [:cmuresan], Formerly of Ecosystem QA - please needinfo @mcoman for things regarding the team]

I have verified that the issue is no longer reproducible on the latest Nightly build (65.0a1, Build ID 	20181107220128) on Windows 10 x64, Mac 10.13.3, and Arch Linux x64. A single card is displayed after refreshing the new tab page and all Recommended cards have been dismissed.

The positioning bug is tracked in bug 1503880.

Comment 5

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

I reproduced this issue using Fx 65.0a1, build ID: 20181107100135, on Windows 10 x64.
I can confirm this issue is fixed, I verified using Fx 64.0b11 and Fx 63.0.3 on Windows 10 x64, macOS 10.13.6 and Ubuntu 16.04 LTS.