1503909 - Running raptor modifies objdir

Status: RESOLVED WONTFIX

(Testing :: Raptor, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

running Raptop adds 
<objdir>/dist/bin/mozilla.cfg
and 
<objdir>/dist/bin/defaults/pref/autoconfig.js

and those get then loaded also when running a FF profile without raptor, and that means all the proxy settings are wrong.

It is possible that I'm seeing the issue because I've ctrl+C'ed raptor run.

But I'd expect raptor to modify the profile data, not objdir.

Comment 1

[Robert Wood [:rwood]]

(In reply to Olli Pettay [:smaug] (high review load) from comment #0)
> running Raptop adds 
> <objdir>/dist/bin/mozilla.cfg
> and 
> <objdir>/dist/bin/defaults/pref/autoconfig.js
> 
> and those get then loaded also when running a FF profile without raptor, and
> that means all the proxy settings are wrong.
> 
> It is possible that I'm seeing the issue because I've ctrl+C'ed raptor run.
> 
> But I'd expect raptor to modify the profile data, not objdir.

Raptor does turn off the Firefox proxy settings after the test finishes, so yes ctrl+c'ing out will leave the proxy settings enabled for future Firefox startups.

Great suggestion, I didn't know that was possible. Can you please tell me how I can turn on proxy settings inside profile data and not in the obj dir? Thanks!

Comment 2

[Robert Wood [:rwood]]

Actually maybe the Raptor webext itself can set the proxy when running on Firefox:

https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/proxy/settings

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

./mach help run
says
  --setpref SETPREF     Set the specified pref before starting the program.
                        Can be set multiple times. Prefs can also be set in
                        ~/.mozbuild/machrc in the [runprefs] section - see
                        `./mach settings` for more information.

perhaps that could be useful?

Comment 4

[Robert Wood [:rwood]]

We don't use autoconfig anymore; we use a policy which is removed after.