1503935 - Crash due animated WebP images

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect, P3)

Description

[sjw]

Firefox Nightly crashes reproducible when displaying animated WebP images.
See the test cases in the referenced url.
It does not crash immediately, but after a while. At times the images flicker or do not appear at all just before crashing.

Crash ID:
https://crash-stats.mozilla.com/report/index/09732bfa-67c6-485c-a9db-32f3f0181101

Comment 1

[sjw]

I forgot to mention, that "image.webp.enabled" need to be enabled.

Comment 2

[Andrew Osmond [:aosmond] (he/him)]

I understand the crash, uber my bad. However I am seeing artifacting on the lossless animated images which is very concerning.

Comment 3

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1503935 - Fix some WebP decoder implementation bugs.

First we did not handle the SourceBufferIterator::WAITING state which
can happen when we get woken up but there is no data to read from the
SourceBufferIterator. StreamingLexer handled this properly by yielding
with NEED_MORE_DATA, and properly scheduling the decoder to resume. This
patch does the same in the WebP decoder.

Second nsWebPDecoder::GetType was not implemented. This meant it would
return DecoderType::UNKNOWN, and would fail to recreate the decoder if
we are discarding frames and need to restart from the beginning. In
addition to implementing that method, this patch also corrects an assert
in DecoderFactory::CloneAnimationDecoder which failed to check for WebP
as a supported animated decoder.

This patch also modestly improves the logging output and library method
checks.

Comment 4

[Andrew Osmond [:aosmond] (he/him)]

(In reply to Andrew Osmond [:aosmond] from comment #2)
> I understand the crash, uber my bad. However I am seeing artifacting on the
> lossless animated images which is very concerning.

I think those may have been caused by the WAITING bug where it would "randomly" stop decoding midway through due to no network traffic.

Comment 5

[Andrew Osmond [:aosmond] (he/him)]

This bug will probably help with some of the intermittents I was seeing on treeherder.

Comment 6

[Andrew Osmond [:aosmond] (he/him)]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=22c4728bface9e80eaf4704af8b6f1eb81e8faa5

Comment 7

[Andrew Osmond [:aosmond] (he/him)]

try with new gtests to exercise functionality that was broken: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6e233bd240e70e64942577400e874f7a18b66b1f

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5223058ac4ff
Fix some WebP decoder implementation bugs. r=tnikkel

Comment 9

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/5223058ac4ff