1503992 - Fix the HAVE_ARM_NEON check for aarch64-windows

Status: NEW

(Firefox Build System :: General, defect)

Description

[(Away)]

aarch64-windwos fails this check: 
https://searchfox.org/mozilla-central/rev/39cb1e96cf97713c444c5a0404d4f84627aee85d/build/autoconf/arch.m4#222

Comment 1

[Nathan Froyd [:froydnj]]

Don't we want a separate define (and possibly test) for HAVE_ARM64_NEON?  Why do we want to fix this check?

Comment 2

[(Away)]

At first glance it is not clear to me what the expectations of code using `#ifdef BUILD_ARM_NEON` are : https://searchfox.org/mozilla-central/search?q=BUILD_ARM_NEON

Maybe in some places it's controlling codepaths that could just as well work on ARM64?

Comment 3

[Makoto Kato [:m_kato]]

(In reply to David Major [:dmajor] from comment #2)
> At first glance it is not clear to me what the expectations of code using
> `#ifdef BUILD_ARM_NEON` are :
> https://searchfox.org/mozilla-central/search?q=BUILD_ARM_NEON
> 
> Maybe in some places it's controlling codepaths that could just as well work
> on ARM64?

See bug 1303952.  We should set BUILD_ARM_NEON on aarch64.  It is only for arm32.

Comment 4

[Makoto Kato [:m_kato]]

sorry.

s/ We should set BUILD_ARM_NEON on aarch64/We shouldn't set BUILD_ARM_NEON on aarch64/

Comment 5

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

Per conversation with :kmoir, I'm going through untriaged bugs in her components and marking the ones which look to be enhancements/tasks with the enhancement severity to get them out of the triage queue.

If this incorrect, please remove the tag.